From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] ubifs: Add zstd support
Date: Fri, 24 Jun 2022 10:16:28 +0200 [thread overview]
Message-ID: <20220624081628.GD1615@pengutronix.de> (raw)
In-Reply-To: <20220623104521.r6hte2qfcusroran@pengutronix.de>
On Thu, Jun 23, 2022 at 12:45:21PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Feb 07, 2022 at 04:14:57PM +0100, Sascha Hauer wrote:
> > zstd shows a good compression rate and is faster than lzo. This adds
> > UBIFS support for it.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> This patch is part of 2022.03.0 with commit cd1610d8ab30 ("ubifs: Add
> zstd support")
>
> Since then there is a warning in my imx builds (using imx_defconfig):
>
> CC fs/ubifs/super.o
> fs/ubifs/super.c: In function ‘validate_inode’:
> fs/ubifs/super.c:89:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
> 89 | if (ui->compr_type >= UBIFS_COMPR_TYPES_CNT) {
> | ^~
>
> That's because UBIFS_COMPR_TYPES_CNT is now 4 and ui->compr_type is an
> unsigned int compr_type:2.
Same here.
>
> I wonder if the check should just be dropped now that all bits are used,
> but I don't feel confident enough to say that's the right thing to do.
The code is the same in the Kernel, but the Kernel has -Wtype-limits
disabled.
I'd say we can remove this check. You could increase your kernel patch
count by suggesting the same there.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2022-06-24 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 15:14 Sascha Hauer
2022-06-23 10:45 ` Uwe Kleine-König
2022-06-24 8:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624081628.GD1615@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox