From: Ahmad Fatoum <ahmad@a3f.at>
To: barebox@lists.infradead.org
Cc: Ahmad Fatoum <ahmad@a3f.at>
Subject: [PATCH master 3/3] scripts: omap3-usb-loader: fix heap overflow
Date: Wed, 31 May 2023 08:27:03 +0200 [thread overview]
Message-ID: <20230531062703.670521-3-ahmad@a3f.at> (raw)
In-Reply-To: <20230531062703.670521-1-ahmad@a3f.at>
Newer GCC versions correctly warn that the buffer allocated by realloc
is too small. Correct the size.
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
scripts/omap3-usb-loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/omap3-usb-loader.c b/scripts/omap3-usb-loader.c
index a8d626c32f23..31a03be8e7f4 100644
--- a/scripts/omap3-usb-loader.c
+++ b/scripts/omap3-usb-loader.c
@@ -784,7 +784,7 @@ int main(int argc, char *argv[])
file.addr = OMAP_BASE_ADDRESS;
/* commit the file object with the processor specified base address */
- args->files = realloc(args->files, filecount);
+ args->files = realloc(args->files, filecount * sizeof(*args->files));
args->numfiles = filecount;
args->files[filecount - 1] = malloc(sizeof (file));
memcpy(args->files[filecount - 1], &file, sizeof (file));
--
2.38.5
next prev parent reply other threads:[~2023-05-31 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 6:27 [PATCH master 1/3] ARM: rockchip: pine64-quartz64: add sdram-init.bin to .gitignore Ahmad Fatoum
2023-05-31 6:27 ` [PATCH master 2/3] scripts: kwbimage: check return value of asprintf Ahmad Fatoum
2023-05-31 6:27 ` Ahmad Fatoum [this message]
2023-05-31 7:28 ` [PATCH master 1/3] ARM: rockchip: pine64-quartz64: add sdram-init.bin to .gitignore Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531062703.670521-3-ahmad@a3f.at \
--to=ahmad@a3f.at \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox