From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH v3 0/2] net: macb: fix dma usage
Date: Wed, 29 Nov 2023 12:33:46 +0100 [thread overview]
Message-ID: <20231129-v2023-08-0-topic-macb-v3-0-65ad6db834dc@pengutronix.de> (raw)
The rx_buffer is only dma_alloc'ed but never properly flushed.
Fix that.
While at it, also use proper volatile access instead of sw barriers.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
Changes in v3:
- fix dma_unmap_single direction
- dma_map_single packet in macb_send()
- Link to v2: https://lore.barebox.org/20231129-v2023-08-0-topic-macb-v2-0-4dc2cb4d5d25@pengutronix.de
Changes in v2:
- change dma_map_single to DMA_FROM_DEVICE
- drop (unsigned long) casts in dma_sync_*
- rework writel/setbits/clearbits to keep semantics
- Link to v1: https://lore.barebox.org/20231128-v2023-08-0-topic-macb-v1-0-9faff73bc990@pengutronix.de
---
Steffen Trumtrar (2):
net: macb: fix dma_alloc for rx_buffer
net: macb: convert to volatile accesses
drivers/net/macb.c | 134 ++++++++++++++++++++++++++++++-----------------------
1 file changed, 77 insertions(+), 57 deletions(-)
---
base-commit: 5f200dd534c848dfa5d948334b6373f0310b8f73
change-id: 20231128-v2023-08-0-topic-macb-0c13ed91179d
Best regards,
--
Steffen Trumtrar <s.trumtrar@pengutronix.de>
next reply other threads:[~2023-11-29 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 11:33 Steffen Trumtrar [this message]
2023-11-29 11:33 ` [PATCH v3 1/2] net: macb: fix dma_alloc for rx_buffer Steffen Trumtrar
2023-11-29 11:59 ` Ahmad Fatoum
2023-11-29 11:33 ` [PATCH v3 2/2] net: macb: convert to volatile accesses Steffen Trumtrar
2023-11-29 12:03 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129-v2023-08-0-topic-macb-v3-0-65ad6db834dc@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox