From: Andrei Lalaev <andrey.lalaev@gmail.com>
To: s.hauer@pengutronix.de
Cc: andrey.lalaev@gmail.com, barebox@lists.infradead.org
Subject: [PATCH] common: fastboot: send FAIL if variable does not exist
Date: Wed, 11 Jun 2025 19:56:45 +0200 [thread overview]
Message-ID: <20250611175645.144025-1-andrey.lalaev@gmail.com> (raw)
According to doc [1], new implementations should send FAIL if the
variable specified in the getvar command does not exist.
[1]: https://android.googlesource.com/platform/system/core/+show/refs/heads/main/fastboot/README.md#121
Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com>
---
common/fastboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/fastboot.c b/common/fastboot.c
index 56bc4e82c4..3df3c227a3 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -372,7 +372,7 @@ static void cb_getvar(struct fastboot *fb, const char *cmd)
goto out;
skip_partitions:
- fastboot_tx_print(fb, FASTBOOT_MSG_OKAY, "");
+ fastboot_tx_print(fb, FASTBOOT_MSG_FAIL, "");
out:
fastboot_free_variables(&partition_list);
}
--
2.49.0
next reply other threads:[~2025-06-11 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 17:56 Andrei Lalaev [this message]
2025-06-12 8:08 ` Sascha Hauer
2025-06-12 14:19 ` Andrei Lalaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250611175645.144025-1-andrey.lalaev@gmail.com \
--to=andrey.lalaev@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox