From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SvRi1-0006q5-2c for barebox@lists.infradead.org; Sun, 29 Jul 2012 11:30:53 +0000 Received: by pbbrq13 with SMTP id rq13so8762518pbb.36 for ; Sun, 29 Jul 2012 04:30:51 -0700 (PDT) From: "Marc Reilly" References: <1343547714-32740-1-git-send-email-marc@cpdesign.com.au> <1343547714-32740-7-git-send-email-marc@cpdesign.com.au> <20120729100036.GD26655@game.jcrosoft.org> In-Reply-To: <20120729100036.GD26655@game.jcrosoft.org> Date: Sun, 29 Jul 2012 21:30:45 +1000 Message-ID: <000601cd6d7d$9aaab230$d0001690$@cpdesign.com.au> MIME-Version: 1.0 Content-Language: en-au Reply-To: marc@cpdesign.com.au List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: RE: [PATCH 6/7] nand: Prevent drivers setting NAND_USE_FLASH_BBT if BBT config not enabled. To: 'Jean-Christophe PLAGNIOL-VILLARD' Cc: barebox@lists.infradead.org > -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@jcrosoft.com] > Sent: Sunday, 29 July 2012 8:01 PM > To: Marc Reilly > Cc: barebox@lists.infradead.org > Subject: Re: [PATCH 6/7] nand: Prevent drivers setting > NAND_USE_FLASH_BBT if BBT config not enabled. > > On 17:41 Sun 29 Jul , Marc Reilly wrote: > > This prevents drivers from setting the options flags to use the flash > > bab block table when the BBT is not enabled in config. > > > > Signed-off-by: Marc Reilly > > --- > > drivers/mtd/nand/atmel_nand.c | 2 +- > > drivers/mtd/nand/nand_imx.c | 2 +- > > drivers/mtd/nand/nand_s3c24xx.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mtd/nand/atmel_nand.c > > b/drivers/mtd/nand/atmel_nand.c index 96624a1..cc62df9 100644 > > --- a/drivers/mtd/nand/atmel_nand.c > > +++ b/drivers/mtd/nand/atmel_nand.c > > @@ -407,7 +407,7 @@ static int __init atmel_nand_probe(struct device_d > *dev) > > } > > } > > > > - if (host->board->on_flash_bbt) { > > + if (IS_ENABLED(CONFIG_NAND_BBT) && host->board- > >on_flash_bbt) { > > printk(KERN_INFO "atmel_nand: Use On Flash BBT\n"); > > nand_chip->options |= NAND_USE_FLASH_BBT; > driver pass this info to the nand framework which is supposed to handle this > by itself Ok, cool. Assuming the nand framework handles this then please drop this patch. Cheers, Narc _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox