From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 28 Jul 2023 16:09:28 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qPO9q-00DZsX-0D for lore@lore.pengutronix.de; Fri, 28 Jul 2023 16:09:28 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPO9n-0005B7-D8 for lore@pengutronix.de; Fri, 28 Jul 2023 16:09:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZpaToXLhN3DK+clNo2ZrR6iP3cfqi6G+bI7jNItuRqQ=; b=GIlTBDwMvvh884/gw/6P+5Ysed k3x517qQ126rdItfhWFvUYV22CxNTLesMge5a4ljuzRfAXQ3YBUY3GU1XmSr7Mny2rbEk+IySQfEi OGBAoGgKd185g7BU5MyeGJDVhr0LpOXDZj0IFPY0xNXX/EmOsoGia4XQZ5zZm7gqxsRgpAODXgAEl 0I8HEAGHM9nvdfeoJ3lrJLI2Rgb55mzxa07ZW42NhpRnrmROFhV3gystUVWzL1luIshTDh9kz64U3 iuxR6Gnx1EqVTc3ZoXpalJsV1jwvThmWT/sNt0ky0Tq3ymts224dx31YWL/Y3Ye2GmCxCfIk60LqS H5VM74LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPO8m-003fnO-05; Fri, 28 Jul 2023 14:08:24 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPO8i-003fmh-1n for barebox@lists.infradead.org; Fri, 28 Jul 2023 14:08:22 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qPO8e-000574-KA; Fri, 28 Jul 2023 16:08:16 +0200 Message-ID: <03383c84-5d30-23fe-a865-80d19c2c23a8@pengutronix.de> Date: Fri, 28 Jul 2023 16:08:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Johannes Zink , barebox@lists.infradead.org Cc: uol@pengutronix.de References: <20230728133158.3828436-1-a.fatoum@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_070820_596558_5B621BB0 X-CRM114-Status: GOOD ( 23.21 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] state: backend_bucket_direct: add debug prints on read/write X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 28.07.23 16:06, Johannes Zink wrote: > Hi Ahmad, > > thanks for your patch. > > On 7/28/23 15:31, Ahmad Fatoum wrote: >> We already have debug prints for the circular backend to help see how >> much data is read/written for each bucket. Add similar debugging info >> for the direct backend as well. Example with stride size of 2048 and >> 44 bytes for the variable set: >> >>    barebox@board:/ state -l >>    state: Read state from 0 length 68 >>    state: Read state from 2048 length 68 >>    state: Read state from 4096 length 68 >> >>    barebox@board:/ state -s >>    state: Written state to offset 0 length 68 data length 60 >>    state: Written state to offset 2048 length 68 data length 60 >>    state: Written state to offset 4096 length 68 data length 60 >> >> Signed-off-by: Ahmad Fatoum >> --- >>   common/state/backend_bucket_direct.c | 14 +++++++++++++- >>   1 file changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/common/state/backend_bucket_direct.c b/common/state/backend_bucket_direct.c >> index f06e14277862..03c752d6fe41 100644 >> --- a/common/state/backend_bucket_direct.c >> +++ b/common/state/backend_bucket_direct.c >> @@ -52,7 +52,7 @@ static int state_backend_bucket_direct_read(struct state_backend_storage_bucket >>       struct state_backend_storage_bucket_direct *direct = >>           get_bucket_direct(bucket); >>       struct state_backend_storage_bucket_direct_meta meta; >> -    uint32_t read_len; >> +    uint32_t read_len, header_len = 0; >>       void *buf; >>       int ret; >>   @@ -72,6 +72,8 @@ static int state_backend_bucket_direct_read(struct state_backend_storage_bucket >>               return -EINVAL; >>             } >> + >> +        header_len = sizeof(meta); >>       } else { >>           if (meta.magic != ~0 && !!meta.magic) >>               bucket->wrong_magic = 1; >> @@ -87,12 +89,16 @@ static int state_backend_bucket_direct_read(struct state_backend_storage_bucket >>                   -errno); >>               return -errno; >>           } >> + >>       } >>         buf = xmalloc(read_len); >>       if (!buf) >>           return -ENOMEM; >>   +    dev_dbg(direct->dev, "Read state from %lld length %d\n", (long long) direct->offset, >> +        header_len + read_len); >> + > > maybe this could use the same message format as for writing (i.e. total length and data length pointed out separately)? I chose it this way for symmetry with the circular backend. > > Best regards > Johannes > >>       ret = read_full(direct->fd, buf, read_len); >>       if (ret < 0) { >>           dev_err(direct->dev, "Failed to read from file, %d\n", ret); >> @@ -112,6 +118,7 @@ static int state_backend_bucket_direct_write(struct state_backend_storage_bucket >>   { >>       struct state_backend_storage_bucket_direct *direct = >>           get_bucket_direct(bucket); >> +    size_t header_len = 0; >>       int ret; >>       struct state_backend_storage_bucket_direct_meta meta; >>   @@ -129,6 +136,8 @@ static int state_backend_bucket_direct_write(struct state_backend_storage_bucket >>               dev_err(direct->dev, "Failed to write metadata to file, %d\n", ret); >>               return ret; >>           } >> + >> +        header_len = sizeof(meta); >>       } else { >>           if (!IS_ENABLED(CONFIG_STATE_BACKWARD_COMPATIBLE)) { >>               dev_dbg(direct->dev, "Too small stride size: must skip metadata! Increase stride size\n"); >> @@ -148,6 +157,9 @@ static int state_backend_bucket_direct_write(struct state_backend_storage_bucket >>           return ret; >>       } >>   +    dev_dbg(direct->dev, "Written state to offset %lld length %zu data length %zu\n", >> +        (long long)direct->offset, len + header_len, len); >> + >>       return 0; >>   } >>   > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |