Re: [PATCH v2 5/8] serial_ns16550: add raspberry pi compatible and init

[Oleksij Rempel <linux@rempel-privat.de>]

[-- Attachment #1.1.1: Type: text/plain, Size: 2130 bytes --]

Hi Rouven,

Am 13.12.18 um 08:44 schrieb Rouven Czerwinski:
> Add the compatible for the Raspberry Pi AUX UART and an init function which
> enables it via the aux register and configures the correct shift value.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
> ---
>  drivers/serial/serial_ns16550.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index 8ddcfdbef..7a4054a67 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -253,6 +253,20 @@ static void ns16550_jz_init_port(struct console_device *cdev)
>  	ns16550_serial_init_port(cdev);
>  }
>  
> +static void rpi_init_port(struct console_device *cdev)
> +{
> +  struct ns16550_priv *priv = to_ns16550_priv(cdev);
> +
> +  writeb(0x01, 0x3f215004);
> +  priv->plat.shift = 2;
> +  /*
> +   * We double the clock rate since the 16550 will divide by 16
> +   * (instead of 8 required by the BCM2835 peripheral manual)
> +   */
> +  priv->plat.clock = priv->plat.clock*2;
> +  ns16550_serial_init_port(cdev);
> +}

Formatting is broken here, you are using spaces instead of tabs.
Probably using checkpatch will show it.

>  /*********** Exposed Functions **********************************/
>  
>  /**
> @@ -353,6 +367,11 @@ static __maybe_unused struct ns16550_drvdata tegra_drvdata = {
>  	.linux_console_name = "ttyS",
>  };
>  
> +static struct ns16550_drvdata rpi_drvdata = {
> +  .init_port = rpi_init_port,
> +  .linux_console_name = "ttyS",
> +};

same here.

>  static int ns16550_init_iomem(struct device_d *dev, struct ns16550_priv *priv)
>  {
>  	struct resource *iores;
> @@ -527,6 +546,12 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
>  		.compatible = "ingenic,jz4740-uart",
>  		.data = &jz_drvdata,
>  	},
> +#endif
> +#if IS_ENABLED(CONFIG_MACH_RPI_COMMON)
> +	{
> +	  .compatible = "brcm,bcm2835-aux-uart",
> +	  .data = &rpi_drvdata,
> +	},
>  #endif
>  	{
>  		/* sentinel */
> 


-- 
Regards,
Oleksij


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox