From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 02 Jun 2021 17:20:21 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1loSfN-00059I-VJ for lore@lore.pengutronix.de; Wed, 02 Jun 2021 17:20:21 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loSfJ-00063D-Fw for lore@pengutronix.de; Wed, 02 Jun 2021 17:20:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=BmYisSIch0lIvgS/iqz24vuTTIs28DMRYJKkEfnELMI=; b=rXVefH/BAMVmtEV/1BExUcqS1Q 49gu3gTtmD0lL2uNV5NTfrngbfwmXSYQXLFZXqnb9zgWQ3NHB3HtGSqf/D4asnvpaEiHivdsqeOz8 4/7T2nFobOgEgIU0VHvWoV/Es0AhzKqn9Dts5r0ySjejdRnIDsIA//SZTiCPpl+S/b8GGBUtegCMP 4vPqKfoPHupD57ZMQpIs2q+051xSavmn9hyRZK2C9aV6iBT5f6MiGP7OWDR3ReIGk0p20dWoCNsdL SAN8UR3ce6QKFjXhCFXCKcE8eIaqqLvu2oBC9lSNrWmFH5jbKKXe1d19D8nsytp70aw+9eG06OvjE 7+j94I1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loSdk-004oJO-6W; Wed, 02 Jun 2021 15:18:40 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1loSda-004oFY-2R for barebox@lists.infradead.org; Wed, 02 Jun 2021 15:18:36 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1loSdY-0005iu-Q9; Wed, 02 Jun 2021 17:18:28 +0200 To: Sascha Hauer , Barebox List References: <20210602095507.24609-1-s.hauer@pengutronix.de> <20210602095507.24609-2-s.hauer@pengutronix.de> From: Ahmad Fatoum Message-ID: <03a2f179-757c-527e-c20c-e1fb8e2accfc@pengutronix.de> Date: Wed, 2 Jun 2021 17:18:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210602095507.24609-2-s.hauer@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210602_081830_149604_92DFE80E X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 01/24] clk: clk-mux: Fix handling of CLK_MUX_HIWORD_MASK X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 02.06.21 11:54, Sascha Hauer wrote: > CLK_MUX_HIWORD_MASK is a flag of the mux clock, not a generic clock > flag. > > Signed-off-by: Sascha Hauer Reviewed-by: Ahmad Fatoum > --- > drivers/clk/clk-mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-mux.c b/drivers/clk/clk-mux.c > index a4743c51b0..7977a76db9 100644 > --- a/drivers/clk/clk-mux.c > +++ b/drivers/clk/clk-mux.c > @@ -34,7 +34,7 @@ static int clk_mux_set_parent(struct clk *clk, u8 idx) > val &= ~(((1 << m->width) - 1) << m->shift); > val |= idx << m->shift; > > - if (clk->flags & CLK_MUX_HIWORD_MASK) > + if (m->flags & CLK_MUX_HIWORD_MASK) > val |= ((1 << m->width) - 1) << (m->shift + 16); > writel(val, m->reg); > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox