Re: [PATCH] ehci-zynq: variscite: tee: fix many typos struct device.

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi,

On 11/27/25 10:23 AM, Lucas Stach wrote:
> Am Mittwoch, dem 26.11.2025 um 23:54 -0500 schrieb
> chalianis1@gmail.com:
>> From: Chali Anis <chalianis1@gmail.com>
>>
>> fix struct device_d to struct device.
> 
> It's not really a typo, as struct device was called struct device_d for
> a long time in barebox. You are fixing the last remnants of that. I'm
> not sure if it's a good idea to lump all those different sites into a
> single patch. At least the subject doesn't really make sense, as zynq,
> a board and tee are not one subsystem.

I use treewide: as prefix such minor patches that just do trivial stuff
like renames. While at it, you could also rename driver_d to driver as well.

> Also, now that you remove the last usages of the deprecated device_d
> you can also remove the
> #define device_d device in driver.h

I would leave that in for out of tree board code to avoid the churn..

Cheers,
Ahmad

> 
> Regards,
> Lucas
> 
>>
>> Signed-off-by: Chali Anis <chalianis1@gmail.com>
>> ---
>>  arch/arm/boards/variscite-som-mx7/board.c | 2 +-
>>  drivers/usb/host/ehci-zynq.c              | 2 +-
>>  include/linux/tee_drv.h                   | 2 +-
>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boards/variscite-som-mx7/board.c b/arch/arm/boards/variscite-som-mx7/board.c
>> index 005228d107af..8bce4ec8616d 100644
>> --- a/arch/arm/boards/variscite-som-mx7/board.c
>> +++ b/arch/arm/boards/variscite-som-mx7/board.c
>> @@ -5,7 +5,7 @@
>>  #include <deep-probe.h>
>>  #include <mach/imx/bbu.h>
>>  
>> -static int var_som_mx7_probe(struct device_d *dev)
>> +static int var_som_mx7_probe(struct device *dev)
>>  {
>>  	imx7_bbu_internal_mmcboot_register_handler("eMMC", "/dev/mmc2", BBU_HANDLER_FLAG_DEFAULT);
>>  	return 0;
>> diff --git a/drivers/usb/host/ehci-zynq.c b/drivers/usb/host/ehci-zynq.c
>> index 13b551d09156..b4b0e0f89100 100644
>> --- a/drivers/usb/host/ehci-zynq.c
>> +++ b/drivers/usb/host/ehci-zynq.c
>> @@ -6,7 +6,7 @@
>>  #include <common.h>
>>  #include <linux/usb/ulpi.h>
>>  
>> -static int zynq_ehci_probe(struct device_d *dev)
>> +static int zynq_ehci_probe(struct device *dev)
>>  {
>>  	struct resource *res;
>>  	void __iomem *base;
>> diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
>> index e2c1042debce..6a8e19459f47 100644
>> --- a/include/linux/tee_drv.h
>> +++ b/include/linux/tee_drv.h
>> @@ -201,7 +201,7 @@ struct tee_shm {
>>  	struct list_head link;
>>  
>>  	int fd;
>> -	struct device_d dev;
>> +	struct device dev;
>>  	struct cdev cdev;
>>  	struct resource res;
>>  };
>>
> 
> 
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |