From: Rouven Czerwinski <r.czerwinski@pengutronix.de>
To: Maik Otto <m.otto@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/4] Makefile-imx: replace static variant to dynamic for signing images
Date: Fri, 24 May 2019 14:55:16 +0200 [thread overview]
Message-ID: <0552fb12e541c7e93ee389bccba26b5fede7b995.camel@pengutronix.de> (raw)
In-Reply-To: <1558697578-69121-1-git-send-email-m.otto@phytec.de>
Hi,
comments as always below.
On Fri, 2019-05-24 at 13:32 +0200, Maik Otto wrote:
> Insert in the Kconfig the selection for the build type signed, usb
> signed,
> encrypted/signed and unsigned as basic for the replacement the
> static
> variant in the Makefile.imx
>
> Signed-off-by: Maik Otto <m.otto@phytec.de>
> ---
> arch/arm/mach-imx/Kconfig | 25 +++++++++++++++++++++++++
> images/Makefile.imx | 1 +
> 2 files changed, 26 insertions(+)
>
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 71d37ce..fdb4239 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -845,6 +845,24 @@ config HABV4_IMG_CRT_PEM
>
> endif
>
> +if HABV4
> +
> +choice
> + prompt "Select Building Signed/Encrypted Bootloader"
> +
> +config HABV4_IMAGE_SIGNED
> + bool "build signed images"
> +
> +config HABV4_IMAGE_SIGNED_USB
> + bool "build signed images and signed USB images"
> +
> +config HABV4_IMAGE_SIGNED_ENCRYPTED
> + bool "build signed encrypted images"
> +
> +endchoice
> +
> +endif
This is a regression in contrast with the current system. The current
systems allows a build of all three images (albeit with a modification
to Makefile.imx), and imo this should be a selection rather than a
choice.
Regards,
Rouven Czerwinski
--
Pengutronix e.K. | |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-05-24 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 11:32 Maik Otto
2019-05-24 11:32 ` [PATCH 2/4] imx6, imx7, imx8: changing hardcoded suffix to variable Maik Otto
2019-05-24 11:32 ` [PATCH 3/4] i.mx6: signed boot: add habv4-imx6-gencsf.h to the flash header of the PHYTEC boards Maik Otto
2019-06-04 15:11 ` Bastian Krause
2019-05-24 11:32 ` [PATCH 4/4] imx6: added fit image signature to the devicetree for " Maik Otto
2019-05-24 12:55 ` Rouven Czerwinski [this message]
2019-05-27 13:08 ` [PATCH 1/4] Makefile-imx: replace static variant to dynamic for signing images Maik Otto
2019-05-28 6:36 ` Rouven Czerwinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0552fb12e541c7e93ee389bccba26b5fede7b995.camel@pengutronix.de \
--to=r.czerwinski@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.otto@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox