From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 12 Feb 2026 10:13:17 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vqSlA-000q5X-0R for lore@lore.pengutronix.de; Thu, 12 Feb 2026 10:13:17 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vqSlA-00050c-9h for lore@pengutronix.de; Thu, 12 Feb 2026 10:13:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n1ZrG5VwQzY8GPiv30M9iY6Zvxmo0Gniuusg3Hfnz3I=; b=go7skj+YNX2QlBTSBY/rwnoPqN AgGU0JgrhQ54m98RQy7l3eirJ13ihEnuXlfd5MAH5DCpZolQpdEJLbzZOyhelcMGn3NHdTw1Xx//X +wORBl7BPB3m26VPOdGUMeAPzquzhsTa3wH8nTxWILGDgy4isO20iYTTFsMCG0kyiKe79JKtolw6N AnUkWyVJd2P25dm+fyeCQ7TTwk1kGPo/syFSy+kme4VpGTmqDzq2V/L/W7zgFp4HDTkTeQnmqxEmo kWnKPkGs0wGzPz5hkNr4ir6hQW+vA3zr9eDDUM3NeSiqwMG3n3HeN75Ckct1ibQNPvpMI33rgMul9 WZ5/n13Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqSjf-00000001okC-1gtZ; Thu, 12 Feb 2026 09:11:43 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqSjc-00000001oic-20Fv for barebox@lists.infradead.org; Thu, 12 Feb 2026 09:11:42 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vqSja-0004u5-Ay for barebox@lists.infradead.org; Thu, 12 Feb 2026 10:11:38 +0100 Message-ID: <057a61ae-5c0e-418a-b7ea-dc5cca9d5460@pengutronix.de> Date: Thu, 12 Feb 2026 10:11:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: barebox@lists.infradead.org References: <20260211-v2025-09-0-topic-optee-of-handling-v3-0-dd83358ae624@pengutronix.de> <20260211-v2025-09-0-topic-optee-of-handling-v3-6-dd83358ae624@pengutronix.de> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: <20260211-v2025-09-0-topic-optee-of-handling-v3-6-dd83358ae624@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260212_011140_523209_FC81AC34 X-CRM114-Status: GOOD ( 30.74 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v3 06/14] ARM: i.MX: scratch: add FDT support X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 2/11/26 11:41 PM, Marco Felsch wrote: > Add support to store a FDT within the scratch area. The user needs to > query the location and size via imx_scratch_get_fdt() which can be used > afterwards to write the actual FDT into it. > > Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum Thanks, Ahmad > --- > arch/arm/mach-imx/scratch.c | 44 ++++++++++++++++++++++++++++++++++--- > include/asm-generic/memory_layout.h | 6 +++++ > include/mach/imx/scratch.h | 2 ++ > security/Kconfig | 15 +++++++++++++ > 4 files changed, 64 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/mach-imx/scratch.c b/arch/arm/mach-imx/scratch.c > index e4e2d25969f061c9fcdfd7c3d87701b715eb2805..fba4b41040a500e31dc4afae2cdcafed0763af6b 100644 > --- a/arch/arm/mach-imx/scratch.c > +++ b/arch/arm/mach-imx/scratch.c > @@ -13,10 +13,22 @@ > #include > > struct imx_scratch_space { > - u32 bootrom_log[128]; > - u32 reserved[128]; /* reserve for bootrom log */ > - struct optee_header optee_hdr; > + union { > + /* Internal buffer, never use directly! */ > + u8 __buf[CONFIG_SCRATCH_SIZE]; > + struct { > + u32 bootrom_log[128]; > + /* reserve for bootrom log */ > + u32 reserved[128]; > + struct optee_header optee_hdr; > + /* FDT needs an 8 byte alignment, always last element! */ > + u8 fdt[] __aligned(8); > + }; > + }; > }; > +/* Ensure that 'fdt' size fits into OP-TEE DTB_MAX_SIZE size */ > +static_assert(sizeof(struct imx_scratch_space) - > + offsetof(struct imx_scratch_space, fdt) >= PBL_OPTEE_DTB_MAX_SIZE); > > static struct imx_scratch_space *scratch; > > @@ -92,3 +104,29 @@ const struct optee_header *imx_scratch_get_optee_hdr(void) > > return &scratch->optee_hdr; > } > + > +u8 *imx_scratch_get_fdt(unsigned int *fdt_sz) > +{ > + unsigned int sz; > + > + if (!scratch) { > + if (IN_PBL) > + return ERR_PTR(-EINVAL); > + else > + scratch = (void *)arm_mem_scratch_get(); > + } > + > + if (PBL_OPTEE_DTB_MAX_SIZE == 0) > + return NULL; > + > + sz = sizeof(struct imx_scratch_space) - > + offsetof(struct imx_scratch_space, fdt); > + > + if (sz > PBL_OPTEE_DTB_MAX_SIZE) > + sz = PBL_OPTEE_DTB_MAX_SIZE; > + > + if (fdt_sz) > + *fdt_sz = sz; > + > + return scratch->fdt; > +} > diff --git a/include/asm-generic/memory_layout.h b/include/asm-generic/memory_layout.h > index 39af73849796fd1954521f0b53bf38fcb0984cef..d477f7bbdbf769a61392da06f2a7b665ce86f5ca 100644 > --- a/include/asm-generic/memory_layout.h > +++ b/include/asm-generic/memory_layout.h > @@ -25,6 +25,12 @@ > #define OPTEE_SHM_SIZE 0 > #endif > > +#ifdef CONFIG_PBL_OPTEE_DTB_MAX_SIZE > +#define PBL_OPTEE_DTB_MAX_SIZE CONFIG_PBL_OPTEE_DTB_MAX_SIZE > +#else > +#define PBL_OPTEE_DTB_MAX_SIZE 0 > +#endif > + > #define HEAD_TEXT_BASE MALLOC_BASE > #define MALLOC_SIZE CONFIG_MALLOC_SIZE > #define STACK_SIZE CONFIG_STACK_SIZE > diff --git a/include/mach/imx/scratch.h b/include/mach/imx/scratch.h > index 6c2cecabcd80f71aa754736322151d63f2711745..b74d19a560f33da0a11621af7e11abdce6d1c295 100644 > --- a/include/mach/imx/scratch.h > +++ b/include/mach/imx/scratch.h > @@ -14,6 +14,8 @@ struct optee_header; > const struct optee_header *imx_scratch_get_optee_hdr(void); > void imx_scratch_save_optee_hdr(const struct optee_header *hdr); > > +u8 *imx_scratch_get_fdt(unsigned int *fdt_sz); > + > #define imx8mq_init_scratch_space() imx8m_init_scratch_space(32, true) > #define imx8mm_init_scratch_space() imx8m_init_scratch_space(32, true) > #define imx8mn_init_scratch_space() imx8m_init_scratch_space(16, true) > diff --git a/security/Kconfig b/security/Kconfig > index 40d468ae07d2b1d4357542df88a0a92eeb3d365f..338bc1e5a72d91bc1617865cacd9d2d8941ca8f5 100644 > --- a/security/Kconfig > +++ b/security/Kconfig > @@ -178,6 +178,21 @@ config PBL_OPTEE > to barebox in THUMB2 mode. Make sure you do not compile barebox in THUMB2 > mode for OP-TEE versions older than this. > > +config PBL_OPTEE_DTB_MAX_SIZE > + hex > + default 0x0 > + prompt "OP-TEE FDT Size" > + help > + The size of the DTB which is passed by the PBL to OP-TEE. This option > + can be left unchanged if OP-TEE DTB support isn't required. If OP-TEE > + DTB support is used, this option must match OP-TEE's CFG_DTB_MAX_SIZE > + configuration. > + > + Note: passing the DTB from the PBL to OP-TEE requires platform > + support. Currently only the i.MX8MMini/Nano/Plus SoCs support this. > + Furthermore your board code must be modified to pass the FDT > + accordingly. > + > endmenu > > source "lib/Kconfig.hardening" > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |