mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Peter Rosin <peda@axentia.se>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Ahmad Fatoum <ahmad@a3f.at>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: at91 sama5d3 "regressions"
Date: Wed, 22 Sep 2021 09:06:03 +0200	[thread overview]
Message-ID: <07c2f7c4-47f3-7fd7-537c-8826da6cb24c@pengutronix.de> (raw)
In-Reply-To: <237cc091-69e4-c49a-9c7b-eb195515da63@axentia.se>

Hi,

On 19.09.21 08:32, Peter Rosin wrote:
> On 2021-09-18 01:57, Peter Rosin wrote:
>> On 2021-09-18 00:37, Peter Rosin wrote:
>>> Hi!
>>>
>>> I have old boards that I'm trying to get up to current
>>> revisions of various pieces of software, and I'm running
>>> into a couple of problems with barebox. After bisecting
>>> and sorting though git history for a couple of days,
>>> these are my findings...
>>
>> I meant to mention that I'm using this extra patch for my board.
>>
>> As you can see, it's been a couple of years, and it is not at
>> all unlikely that the root cause is in these files, and that
>> there has been changes in the other parts of the sama5d3 code
>> that I need to pick up.
>>
>> I will dig into updating these files, and check if that help.
> 
> Ok, it turns out I don't need to do that update, because the
> only thing that's actually used from the extra patch are the
> tse850_defconfig file and the environment. But since the
> tse850_defconfig file fails to set CONFIG_MACH_TSE850, the
> actual code in the extra patch is not used (not even compiled).
> Instead, the board code for sama5d3x is what I have been using
> all along. Big blush about that, and sorry for the confusion!

No worries.

> However, the above also means that the quotes around the
> "regressions" word in the subject can be removed. The problems
> are squarely in the upstream code base, and I do need fixes
> for region overlap, eXecute Never and RO_DATA_SECTION.

I am interested in understanding how that breakage came about.
I have a sama5d3_xplained here with NAND, which I will try to
find some time to reproduce this on.

For your immediate issue: I'd like to use the occasion to get
all sama5d3 to probe from device tree. We already have one
sama5d3 DT-enabled board upstream (microchip-ksz9477-evb) and
I just CC'd you on a series to migrate the sama5d3_xplained
from legacy board code to DT. I tested this boots correctly
after at91bootstrap from NAND without your series here.

The relevant defconfig is at91_multi_defconfig. It will generate
a barebox-sama5d3-xplained.img, which should boot to shell
on your board.

If that works, we could create a new barebox-sama5d3xek.img image
that does the same as barebox-sama5d3-xplained.img, but with
different device tree and see if all peripherals you use
still work.


With everything nice and dandy, we could finally remove non-DT
code for sama5d3 altogether and your board would reuse the same
early bootstrap code basically all other platforms use and test.

Sounds good?

Cheers,
Ahmad

> 
> I have this hunch that the region overlap is what triggers
> the other problems, but that's a pretty wild guess...
> 
> Cheers,
> Peter
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox


  reply	other threads:[~2021-09-22  7:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 22:37 Peter Rosin
2021-09-17 22:39 ` [PATCH 1/4] common.h: reintroduce region_overlap() as, old_region_overlap() Peter Rosin
2021-09-17 22:39 ` [PATCH 2/4] ARM: copy data if there is a region overlap Peter Rosin
2021-09-17 22:40 ` [PATCH 3/4] Revert "ARM: mmu: use client domain permissions to support ARMv7 eXecute Never" Peter Rosin
2021-09-19  7:06   ` Rouven Czerwinski
2021-09-19  7:50     ` Peter Rosin
2021-09-19 20:33       ` Peter Rosin
2021-09-20  9:14       ` Ahmad Fatoum
2021-09-20 10:22         ` Peter Rosin
2021-09-17 22:41 ` [PATCH 4/4] lds: the RO_DATA_SECTION macro does not work on my SAMA5D3 board Peter Rosin
2021-09-17 23:57 ` at91 sama5d3 "regressions" Peter Rosin
2021-09-19  6:32   ` Peter Rosin
2021-09-22  7:06     ` Ahmad Fatoum [this message]
2021-09-22  7:41       ` Peter Rosin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07c2f7c4-47f3-7fd7-537c-8826da6cb24c@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=ahmad@a3f.at \
    --cc=barebox@lists.infradead.org \
    --cc=peda@axentia.se \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox