From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Matteo Fortini <matteo.fortini@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] sama5d3x: fix AT91_SMC_CS offset stride
Date: Thu, 29 May 2014 20:11:41 +0800 [thread overview]
Message-ID: <08875C68-8986-4E67-A4ED-2C3F9C203A73@jcrosoft.com> (raw)
In-Reply-To: <1401357333-6426-1-git-send-email-matteo.fortini@gmail.com>
On May 29, 2014, at 5:55 PM, Matteo Fortini <matteo.fortini@gmail.com> wrote:
>
> Acked-by: Bo Shen <voice.shen@atmel.com>
> ---
> arch/arm/mach-at91/sam9_smc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-at91/sam9_smc.c b/arch/arm/mach-at91/sam9_smc.c
> index a137da4..65c4558 100644
> --- a/arch/arm/mach-at91/sam9_smc.c
> +++ b/arch/arm/mach-at91/sam9_smc.c
> @@ -16,7 +16,11 @@
>
> #include <mach/at91sam9_smc.h>
>
> +#ifdef CONFIG_ARCH_SAMA5D3
> +#define AT91_SMC_CS(id, n) (smc_base_addr[id] + ((n) * 0x14))
> +#else
> #define AT91_SMC_CS(id, n) (smc_base_addr[id] + ((n) * 0x10))
> +#endif
NACK no ifdef
this need to be runtime
and you need to put our SOB
>
> static void __iomem *smc_base_addr[2];
>
> --
> 2.0.0.rc2
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-29 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 9:55 Matteo Fortini
2014-05-29 12:11 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2014-05-30 1:43 ` Bo Shen
-- strict thread matches above, loose matches on Subject: below --
2014-05-28 17:16 [PATCH] SAMA5D3X FIX " Matteo Fortini
2014-05-29 1:31 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08875C68-8986-4E67-A4ED-2C3F9C203A73@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=matteo.fortini@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox