From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 21 Jul 2021 10:42:53 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1m67ob-0003xk-FJ for lore@lore.pengutronix.de; Wed, 21 Jul 2021 10:42:53 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m67oa-0000Lg-G1 for lore@pengutronix.de; Wed, 21 Jul 2021 10:42:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7WZNQCUr6ld8+SGnYbo/MpMwK5RIJ/yVx8FmFvDqKe0=; b=BplR4ai1R0UU0P 4z0gA4nmPsbvBVAeMSFCKFIC1XJKzxyZPnAU1qkGlbEHJwWwPDlpKcgNVqgZ94TpZHt77IZze+Ceq uZNWGlSqR+5Ezbac5Ktmd4UN9McN6OXVDvbQ18NyyJhsWLtChn6fxfrnhEndMSt1kbdd+RaoovRlq 9Ltu8enT86T8S1/i86XdqS9Z9SdxAvytIZxeAmoI9jb4ZnjLI3AOOe9tkGCVf9G6s64CqsN33EDNb 3gG4jo8CM7i1wf5B2Gma3KeiMNrxDH4IUSGQRXio0O5EKlF3ncEWbQIsoWVAyWlCuRpnxITucSG0Y 1Ar/2SP70Sst78CT++8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67nH-00Ex92-2K; Wed, 21 Jul 2021 08:41:31 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m67n7-00Ex5d-83 for barebox@lists.infradead.org; Wed, 21 Jul 2021 08:41:22 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m67n4-0008W5-1h; Wed, 21 Jul 2021 10:41:18 +0200 Message-ID: <0896c797ae08407add4538e68fafc38eb2ec0a68.camel@pengutronix.de> From: Rouven Czerwinski To: Ahmad Fatoum , barebox@lists.infradead.org Date: Wed, 21 Jul 2021 10:41:17 +0200 In-Reply-To: <577c9a3b-ccf2-f52a-03cd-311bd95e28fb@pengutronix.de> References: <20210721075051.393141-1-r.czerwinski@pengutronix.de> <577c9a3b-ccf2-f52a-03cd-311bd95e28fb@pengutronix.de> Organization: Pengutronix e.K. User-Agent: Evolution 3.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_014121_347762_CCFB3CD4 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:e::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] fastboot: handle error from file_list_parse() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On Wed, 2021-07-21 at 10:03 +0200, Ahmad Fatoum wrote: > Hello Rouven, > > On 21.07.21 09:50, Rouven Czerwinski wrote: > > In case an invalid file list is passed to file_list_parse(), it will > > return an error, i.e. by passing "/dev/mmc1(emmc) /dev/mmc1.1(root)", > > the error here being that the entries are not comma separated and > > file_list_parse will try to parse ' ' as a flag. The fastboot code > > didn't handle this, leading to the following error: > > > > ERROR: file_list: Unknown flag ' ' > > ERROR: file_list: parse error > > unable to handle paging request at address 0xfffffff2 > > pc : [<8fe26a20>] lr : [<8fe0f965>] > > sp : 8ffeff50 ip : 8ffef714 fp : 00079bda > > r10: 001b9ff8 r9 : 8fea7eec r8 : 00000001 > > r7 : 00000000 r6 : 00000001 r5 : 00000000 r4 : 8813eab0 > > r3 : ffffffea r2 : 00020000 r1 : 00000001 r0 : 8813eab0 > > Flags: nzCv IRQs off FIQs off Mode SVC_32 > > WARNING: [<8fe26a20>] (usb_multi_count_functions+0xc/0x2a) from [<8fe0f965>] (usbgadget_register+0x79/0xf4) > > WARNING: [<8fe0f965>] (usbgadget_register+0x79/0xf4) from [<8fe0fa13>] (usbgadget_autostart_set+0x33/0x4c) > > WARNING: [<8fe0fa13>] (usbgadget_autostart_set+0x33/0x4c) from [<8fe4d437>] (param_int_set+0x4b/0xb0) > > WARNING: [<8fe4d437>] (param_int_set+0x4b/0xb0) from [<8fe4d899>] (dev_set_param+0x4d/0x64) > > WARNING: [<8fe4d899>] (dev_set_param+0x4d/0x64) from [<8fe066f1>] (globalvar_add_bool+0x49/0x54) > > WARNING: [<8fe066f1>] (globalvar_add_bool+0x49/0x54) from [<8fe0f8dd>] (usbgadget_autostart_init+0x15/0x24) > > WARNING: [<8fe0f8dd>] (usbgadget_autostart_init+0x15/0x24) from [<8fe01081>] (start_barebox+0x35/0x6c) > > WARNING: [<8fe01081>] (start_barebox+0x35/0x6c) from [<8fe62ed9>] (barebox_non_pbl_start+0x121/0x164) > > WARNING: [<8fe62ed9>] (barebox_non_pbl_start+0x121/0x164) from [<8fe00005>] (__bare_init_start+0x1/0xc) > > > > WARNING: [<8fe64e3d>] (unwind_backtrace+0x1/0x78) from [<8fe01385>] (panic+0x1d/0x34) > > WARNING: [<8fe01385>] (panic+0x1d/0x34) from [<8fe62723>] (do_exception+0xf/0x14) > > WARNING: [<8fe62723>] (do_exception+0xf/0x14) from [<8fe62791>] (do_data_abort+0x21/0x34) > > WARNING: [<8fe62791>] (do_data_abort+0x21/0x34) from [<8fe624d4>] (do_abort_6+0x48/0x54) > > > > Add the proper error handling and notify the user with a proper error message. > > get_dfu_function() suffers from the same issue. There is already a parse function in > common/usbgadget.c that warns and returns NULL. Could you move that somewhere > central and use it for both fastboot and dfu? Sounds good, I send an updated patch series to the list which moves the parse function to file-list.h and renames it to file_list_parse_null(). Regards, Rouven _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox