From: Lucas Stach <l.stach@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: configs: imx_v7_defconfig: add missing RELOCATABLE
Date: Fri, 02 Oct 2020 13:23:19 +0200 [thread overview]
Message-ID: <08a96424e3c552ec7ddfd37f1bcff54f6ac7921e.camel@pengutronix.de> (raw)
In-Reply-To: <20201002111452.30547-1-m.felsch@pengutronix.de>
On Fr, 2020-10-02 at 13:14 +0200, Marco Felsch wrote:
> All barebox images should be relocatable per default. The user needs to
> turn of this option on purpose rather than turning it on. Currently this
> option was selected by selecting MACH_CCMX51. Deselecting this board
> support ended in deselecting CONFIG_RELOCATABLE.
Shouldn't this rather be selected by IMX_MULTI_BOARDS or soemthing
similar? Otherwise one would need to find a ARCH_TEXT_BASE compatible
with all the enabled boards, which is probably a bit too much config
hell to dump onto the users.
Regards,
Lucas
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> arch/arm/configs/imx_v7_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/imx_v7_defconfig b/arch/arm/configs/imx_v7_defconfig
> index 5dcdff0638..c55df0357d 100644
> --- a/arch/arm/configs/imx_v7_defconfig
> +++ b/arch/arm/configs/imx_v7_defconfig
> @@ -208,3 +208,4 @@ CONFIG_FS_FAT_LFN=y
> CONFIG_FS_UBIFS=y
> CONFIG_FS_UBIFS_COMPRESSION_LZO=y
> CONFIG_PNG=y
> +CONFIG_RELOCATABLE=y
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-10-02 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 11:14 Marco Felsch
2020-10-02 11:23 ` Lucas Stach [this message]
2020-10-02 12:07 ` Sascha Hauer
2020-10-02 13:06 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08a96424e3c552ec7ddfd37f1bcff54f6ac7921e.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox