From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 09 Jun 2022 16:14:02 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzIvC-008nni-KM for lore@lore.pengutronix.de; Thu, 09 Jun 2022 16:14:02 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzIvB-0006bT-H5 for lore@pengutronix.de; Thu, 09 Jun 2022 16:14:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m/OwD+VXAZ1lLsU11mnmByjrE9Fas1W8DHEbnPC6U/U=; b=MaAJ02sd98ctFs Rao+73hGmhvcFzi3+2SVj4bGfWff1TIVG2CJifbcYOuXcJH7hCmJBVEj9xiPqpuzoZwSAp2js8Jkm EveWHFuIVI0YxMxR2eIccaBcVampzmcxe3lwiJdvy7fMBlDd+5bjZAKlpjERG8LXW/ppu6o0Ljssd Q+cqeNwn/kTS12KiDX7tFKSqOiAHyJMn+Lf0c/3sEBrpkQR7y8qMMORVrLG6WjHUae6uGvSa2Rfm6 iiK6A/WGXYYyXvBzH/w1qkLPXAAiAUJjyjA8KLR0Wic6aHLhIRlLI7DDuNup+pN9bL+DmGel+1RMT ajcajdMtvYpuYfUNv7PQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzIu1-002Q6S-Ds; Thu, 09 Jun 2022 14:12:49 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzItt-002Q3z-Rs for barebox@lists.infradead.org; Thu, 09 Jun 2022 14:12:45 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nzIts-0006Um-4T; Thu, 09 Jun 2022 16:12:40 +0200 Message-ID: <0bc9c029-ee77-ae1c-f9a5-083c3db5544a@pengutronix.de> Date: Thu, 9 Jun 2022 16:12:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: Sascha Hauer Cc: barebox@lists.infradead.org References: <20220609130936.3616309-1-a.fatoum@pengutronix.de> <20220609130936.3616309-2-a.fatoum@pengutronix.de> <20220609141038.GW1615@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20220609141038.GW1615@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220609_071241_952947_E1376DB0 X-CRM114-Status: GOOD ( 21.39 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v3 2/2] fastboot: bail if update handler couldn't be found for bbu-partition X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 09.06.22 16:10, Sascha Hauer wrote: > On Thu, Jun 09, 2022 at 03:09:36PM +0200, Ahmad Fatoum wrote: >> Fastboot would fall back to a raw copy even for bbu- partitions if >> no barebox_update handler was found. Prevent this by bailing out >> with an error code. >> >> Signed-off-by: Ahmad Fatoum >> --- >> v2 -> v3: >> - bail out instead of only printing message and falling back >> to raw copy (Sascha) >> v1 -> v2: >> - print message in case barebox_update handler is not found >> --- >> common/fastboot.c | 9 +++++++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/common/fastboot.c b/common/fastboot.c >> index 330a06f5a32f..a5cf04b39ecd 100644 >> --- a/common/fastboot.c >> +++ b/common/fastboot.c >> @@ -683,8 +683,13 @@ static void cb_flash(struct fastboot *fb, const char *cmd) >> }; >> >> handler = bbu_find_handler_by_device(data.devicefile); >> - if (!handler) >> - goto copy; >> + if (!handler) { >> + fastboot_tx_print(fb, FASTBOOT_MSG_FAIL, >> + "No barebox update handler registered for %s", >> + data.devicefile); >> + ret = -ENOENT; >> + goto out; >> + } > > I didn't verify that, but I believe a full raw bootable disk image > generated for i.MX will be detected as barebox image. With this patch we > wouldn't be able to flash that anymore. Can we just apply v2 and see how often we see the message? > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox