mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: Giorgio Dal Molin <giorgio.nicole@arcor.de>, barebox@lists.infradead.org
Subject: Re: suspicious header files diff
Date: Fri, 20 Mar 2020 18:16:44 +0100	[thread overview]
Message-ID: <0ebd04c8fc9b8cb431e7bb04ce50ad7f208c9a24.camel@lynxeye.de> (raw)
In-Reply-To: <1083579.30874.1584708448026@mail.vodafone.de>

Hi Giorgio,

thanks for the report. I've sent a patch to fix this issue.

Regards,
Lucas

Am Freitag, den 20.03.2020, 13:47 +0100 schrieb Giorgio Dal Molin:
> Hi,
> 
> I'm getting a compile error while building barebox for an imx7d after
> configuring in CONFIG_RESET_IMX7:
> 
> ...
>   CHK     include/generated/compile.h
>   CC      drivers/reset/reset-imx7.o
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: error: 'IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N'?
>   181 |  [IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N] = { SRC_MIPIPHY_RCR, BIT(3) },
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |   IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: error: array index in initializer not of integer type
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:181:3: note: (near initialization for 'imx8mq_src_signals')
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: error: 'IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N'?
>   182 |  [IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N] = { SRC_MIPIPHY_RCR, BIT(4) },
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |   IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: error: array index in initializer not of integer type
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:182:3: note: (near initialization for 'imx8mq_src_signals')
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: error: 'IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N' undeclared here (not in a function); did you mean 'IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N'?
>   183 |  [IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N] = { SRC_MIPIPHY_RCR, BIT(5) },
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |   IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: error: array index in initializer not of integer type
> /home/giorgio/projects/wpt_barebox/drivers/reset/reset-imx7.c:183:3: note: (near initialization for 'imx8mq_src_signals')
> make[3]: *** [/home/giorgio/projects/wpt_barebox/scripts/Makefile.build:215: drivers/reset/reset-imx7.o] Error 1
> make[2]: *** [/home/giorgio/projects/wpt_barebox/scripts/Makefile.build:367: drivers/reset] Error 2
> make[1]: *** [/home/giorgio/projects/wpt_barebox/Makefile:804: drivers] Error 2
> make: *** [Makefile:118: sub-make] Error 2
> 
> 
> After a bit of search I've found the following two nearly identical headers:
> 
>  -1- include/dt-bindings/reset/imx8mq-reset.h
>  -2- dts/include/dt-bindings/reset/imx8mq-reset.h
> 
> maybe there is a typo (DSI <=> DIS):
> 
> #define IMX8MQ_RESET_MIPI_DSI_DPI_RESET_N	23
> #define IMX8MQ_RESET_MIPI_DSI_ESC_RESET_N	24
> #define IMX8MQ_RESET_MIPI_DSI_PCLK_RESET_N	25
> 
> #define IMX8MQ_RESET_MIPI_DIS_DPI_RESET_N	23
> #define IMX8MQ_RESET_MIPI_DIS_ESC_RESET_N	24
> #define IMX8MQ_RESET_MIPI_DIS_PCLK_RESET_N	25
> 
> giorgio
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2020-03-20 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 12:47 Giorgio Dal Molin
2020-03-20 17:16 ` Lucas Stach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ebd04c8fc9b8cb431e7bb04ce50ad7f208c9a24.camel@lynxeye.de \
    --to=dev@lynxeye.de \
    --cc=barebox@lists.infradead.org \
    --cc=giorgio.nicole@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox