From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 20 Feb 2025 13:07:42 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tl5LD-004hgl-0p for lore@lore.pengutronix.de; Thu, 20 Feb 2025 13:07:42 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tl5LC-0004zZ-2d for lore@pengutronix.de; Thu, 20 Feb 2025 13:07:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5scK44MYTo75wsbZ/A+PTHevY/RhXj3j30TF7nlAsjo=; b=ZpVPiQaDwgKkrbacj5NNmkNAh6 gDgm2vVps2sodtB2aWN0O/W93zy60uYRHiVm+EfGLGFTSzU8SeGXLgVUZ/1tI8Hj+vL6vJph2pYVY X8oxkJ8lxZsjUqlsbxzBiF20w0uB2m6WAnkaLb3t9FTF7B8639Jvx9txw0VbS+1zyDIHbUo1+qnVH 5eeTuqv8o80iMD6Nd/fUJZ7x1VU1BVGhj3mQ2NR/JZvl864js0Wu5ZUm4nQYs+2TUbXt+pV0K7VxO rHbgvQaiLQUUNUXnWsp6iJBtEa/cTNCwG/t8xPjYWt3Xff//UAt3EaTqkAO5xj4fRDettCNB7sy7I uu1w1Plg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tl5KU-00000000hog-0kok; Thu, 20 Feb 2025 12:06:58 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tl5KR-00000000hmv-0XRo for barebox@lists.infradead.org; Thu, 20 Feb 2025 12:06:56 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tl5KP-0004rN-Pu; Thu, 20 Feb 2025 13:06:53 +0100 Message-ID: <1058511f-b54e-44be-b267-dce2b1fd048a@pengutronix.de> Date: Thu, 20 Feb 2025 13:06:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer , Barebox List References: <20250220091743.3489127-1-s.hauer@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: <20250220091743.3489127-1-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250220_040655_175422_DAA383EE X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] boot: fix systemd watchdog command line argument X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 20.02.25 10:17, Sascha Hauer wrote: > The kernel command line option to specify the watchdog to use is > "systemd.watchdog_device" as specified in [1], not > "systemd.watchdog-device" > > [1] https://www.freedesktop.org/software/systemd/man/latest/kernel-command-line.html#systemd.watchdog_sec= > > Signed-off-by: Sascha Hauer Please also include the typo fix in the common/Kconfig help text for CONFIG_SYSTEMD_OF_WATCHDOG. With that squashed: Reviewed-by: Ahmad Fatoum I could swear I have tested this with two watchdogs back then... Anyways, I have submitted a fix to the systemd documentation here: https://github.com/systemd/systemd/pull/36453 Thanks, Ahmad > --- > common/oftree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/oftree.c b/common/oftree.c > index 4afe955719..2ebde791c7 100644 > --- a/common/oftree.c > +++ b/common/oftree.c > @@ -172,7 +172,7 @@ static void watchdog_build_bootargs(struct watchdog *watchdog, struct device_nod > if (alias_id < 0) > return; > > - buf = basprintf("systemd.watchdog-device=/dev/watchdog%d", alias_id); > + buf = basprintf("systemd.watchdog_device=/dev/watchdog%d", alias_id); > if (!buf) > return; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |