From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] mci: sdhci: atmel: use dev_printf instead of pr_print in common code
Date: Tue, 23 Jun 2020 12:05:32 +0200 [thread overview]
Message-ID: <1259d972-2bdd-68c4-9826-eee7bb6c7141@pengutronix.de> (raw)
In-Reply-To: <20200623094636.GY11869@pengutronix.de>
On 6/23/20 11:46 AM, Sascha Hauer wrote:
> On Mon, Jun 22, 2020 at 10:39:42AM +0200, Ahmad Fatoum wrote:
>> On boards like the sama5d27 som1 ek, we have two SD card slots, so error
>> messages are more useful if they refer to the SDHCI instance. We didn't
>> do this at first, because the common code is compiled for PBL as well.
>> With a sprinkle of preprocessor ifdeffery, we can have both.
>>
>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>> ---
>> drivers/mci/atmel-sdhci-common.c | 14 +++++++++-----
>> drivers/mci/atmel-sdhci.c | 2 ++
>> drivers/mci/atmel-sdhci.h | 1 +
>> 3 files changed, 12 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/mci/atmel-sdhci-common.c b/drivers/mci/atmel-sdhci-common.c
>> index 060d1c33d1a5..a83610c3d090 100644
>> --- a/drivers/mci/atmel-sdhci-common.c
>> +++ b/drivers/mci/atmel-sdhci-common.c
>> @@ -16,6 +16,10 @@
>>
>> #ifdef __PBL__
>> #define udelay early_udelay
>> +#undef dev_err
>> +#define dev_err(d, ...) pr_err(__VA_ARGS__)
>> +#undef dev_warn
>> +#define dev_warn(d, ...) pr_warn(__VA_ARGS__)
>> #endif
>
> This hunk doesn't apply. Is a patch missing in this series?
I have a series for first stage support, but picked out the second stage relevant
parts to slim it down. I'll rebase and resend v2.
>
> Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-06-23 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 8:39 [PATCH 1/3] mci: sdhci: atmel: don't print errors on command timeouts Ahmad Fatoum
2020-06-22 8:39 ` [PATCH 2/3] mci: sdhci: atmel: use dev_printf instead of pr_print in common code Ahmad Fatoum
2020-06-23 9:46 ` Sascha Hauer
2020-06-23 10:05 ` Ahmad Fatoum [this message]
2020-06-22 8:39 ` [PATCH 3/3] mci: sdhci: atmel: avoid buggy SDHCI_RESET_ALL Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259d972-2bdd-68c4-9826-eee7bb6c7141@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox