From: Marek Belisko <marek.belisko@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH] serial_s3c24x0: Add missing brackets.
Date: Mon, 15 Nov 2010 15:17:19 +0100 [thread overview]
Message-ID: <1289830639-26626-1-git-send-email-marek.belisko@gmail.com> (raw)
Fucntion s3c24x0_serial_flush() could behave wrong
because of missing brackets. Correct condition logic.
Problem found by sparse.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
---
drivers/serial/serial_s3c24x0.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/serial_s3c24x0.c b/drivers/serial/serial_s3c24x0.c
index fedddd3..d7eac8f 100644
--- a/drivers/serial/serial_s3c24x0.c
+++ b/drivers/serial/serial_s3c24x0.c
@@ -113,7 +113,7 @@ static void s3c24x0_serial_flush(struct console_device *cdev)
{
struct device_d *dev = cdev->dev;
- while (!readb(dev->map_base + UTRSTAT) & 0x4)
+ while (!(readb(dev->map_base + UTRSTAT) & 0x4))
;
}
--
1.7.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2010-11-15 14:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289830639-26626-1-git-send-email-marek.belisko@gmail.com \
--to=marek.belisko@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox