* [PATCH] serial_s3c24x0: Add missing brackets.
@ 2010-11-15 14:17 Marek Belisko
0 siblings, 0 replies; only message in thread
From: Marek Belisko @ 2010-11-15 14:17 UTC (permalink / raw)
To: barebox
Fucntion s3c24x0_serial_flush() could behave wrong
because of missing brackets. Correct condition logic.
Problem found by sparse.
Signed-off-by: Marek Belisko <marek.belisko@gmail.com>
---
drivers/serial/serial_s3c24x0.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/serial_s3c24x0.c b/drivers/serial/serial_s3c24x0.c
index fedddd3..d7eac8f 100644
--- a/drivers/serial/serial_s3c24x0.c
+++ b/drivers/serial/serial_s3c24x0.c
@@ -113,7 +113,7 @@ static void s3c24x0_serial_flush(struct console_device *cdev)
{
struct device_d *dev = cdev->dev;
- while (!readb(dev->map_base + UTRSTAT) & 0x4)
+ while (!(readb(dev->map_base + UTRSTAT) & 0x4))
;
}
--
1.7.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-11-15 14:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-15 14:17 [PATCH] serial_s3c24x0: Add missing brackets Marek Belisko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox