From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/7] mci mxs: put only once used function inline
Date: Mon, 28 Feb 2011 10:43:50 +0100 [thread overview]
Message-ID: <1298886235-1769-3-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1298886235-1769-1-git-send-email-s.hauer@pengutronix.de>
Also, rename mci_rename after the callback it implements: stm_mci_initialize.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mci/mxs.c | 27 ++++++++-------------------
1 files changed, 8 insertions(+), 19 deletions(-)
diff --git a/drivers/mci/mxs.c b/drivers/mci/mxs.c
index 94b0f4a..db789e7 100644
--- a/drivers/mci/mxs.c
+++ b/drivers/mci/mxs.c
@@ -595,13 +595,17 @@ static void stm_mci_reset(struct device_d *hw_dev)
;
}
+/* ------------------------- MCI API -------------------------------------- */
+
/**
- * Initialize the engine
- * @param hw_dev Host interface instance
+ * Keep the attached MMC/SD unit in a well know state
+ * @param mci_pdata MCI platform data
* @param mci_dev MCI device instance
+ * @return 0 on success, negative value else
*/
-static int stm_mci_initialize(struct device_d *hw_dev, struct device_d *mci_dev)
+static int stm_mci_initialize(struct mci_host *mci_pdata, struct device_d *mci_dev)
{
+ struct device_d *hw_dev = mci_pdata->hw_dev;
struct mci_host *host = GET_MCI_PDATA(mci_dev);
struct stm_mci_host *host_data = (struct stm_mci_host*)GET_HOST_DATA(hw_dev);
@@ -624,21 +628,6 @@ static int stm_mci_initialize(struct device_d *hw_dev, struct device_d *mci_dev)
return 0;
}
-/* ------------------------- MCI API -------------------------------------- */
-
-/**
- * Keep the attached MMC/SD unit in a well know state
- * @param mci_pdata MCI platform data
- * @param mci_dev MCI device instance
- * @return 0 on success, negative value else
- */
-static int mci_reset(struct mci_host *mci_pdata, struct device_d *mci_dev)
-{
- struct device_d *hw_dev = mci_pdata->hw_dev;
-
- return stm_mci_initialize(hw_dev, mci_dev);
-}
-
/**
* Process one command to the MCI card
* @param mci_pdata MCI platform data
@@ -733,7 +722,7 @@ static int stm_mci_probe(struct device_d *hw_dev)
host->hw_dev = hw_dev;
host->send_cmd = mci_request,
host->set_ios = mci_set_ios,
- host->init = mci_reset,
+ host->init = stm_mci_initialize,
/* feed forward the platform specific values */
host->voltages = pd->voltages;
--
1.7.2.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-02-28 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 9:43 mmc: i.MX23/28 patches Sascha Hauer
2011-02-28 9:43 ` [PATCH 1/7] mci i.MX23/28: rename driver to mxs.c Sascha Hauer
2011-02-28 9:43 ` Sascha Hauer [this message]
2011-02-28 9:43 ` [PATCH 3/7] mci mxs: give functions a uniq mxs_mci_ namespace Sascha Hauer
2011-02-28 9:43 ` [PATCH 4/7] mci mxs: rename mci_pdata to host Sascha Hauer
2011-02-28 9:43 ` [PATCH 5/7] mci mxs: make the mci_host a member of mxs_mci_host Sascha Hauer
2011-02-28 9:43 ` [PATCH 6/7] mci mxs: no need to call mxs_mci_setup_clock_speed in init Sascha Hauer
2011-02-28 9:43 ` [PATCH 7/7] ARM tx28stk5: limit mmc max frequency to 25MHz Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298886235-1769-3-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox