From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 2/5] nand omap: turn debug messages into dev_dbg
Date: Mon, 11 Apr 2011 16:10:33 +0200 [thread overview]
Message-ID: <1302531036-27906-3-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1302531036-27906-1-git-send-email-s.hauer@pengutronix.de>
The information from the probe function is useful for developers
only, so turn them into dev_dbg to safe binary space.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/mtd/nand/nand_omap_gpmc.c | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/mtd/nand/nand_omap_gpmc.c b/drivers/mtd/nand/nand_omap_gpmc.c
index 74ef1ac..74f2da6 100644
--- a/drivers/mtd/nand/nand_omap_gpmc.c
+++ b/drivers/mtd/nand/nand_omap_gpmc.c
@@ -682,13 +682,13 @@ static int gpmc_nand_probe(struct device_d *pdev)
gpmcnand_dbg("pdev=%x", (unsigned int)pdev);
pdata = (struct gpmc_nand_platform_data *)pdev->platform_data;
if (pdata == NULL) {
- gpmcnand_err("platform data missing\n");
+ dev_dbg(pdev, "platform data missing\n");
return -ENODEV;
}
oinfo = calloc(1, sizeof(struct gpmc_nand_info));
if (!oinfo) {
- gpmcnand_err("oinfo alloc failed!\n");
+ dev_dbg(pdev, "oinfo alloc failed!\n");
return -ENOMEM;
}
@@ -705,7 +705,7 @@ static int gpmc_nand_probe(struct device_d *pdev)
minfo->priv = (void *)nand;
if (pdata->cs >= GPMC_NUM_CS) {
- gpmcnand_err("Invalid CS!\n");
+ dev_dbg(pdev, "Invalid CS!\n");
err = -EINVAL;
goto out_release_mem;
}
@@ -729,7 +729,7 @@ static int gpmc_nand_probe(struct device_d *pdev)
/* If we are 16 bit dev, our gpmc config tells us that */
if ((readl(cs_base) & 0x3000) == 0x1000) {
- debug("16 bit dev\n");
+ dev_dbg(pdev, "16 bit dev\n");
nand->options |= NAND_BUSWIDTH_16;
}
@@ -744,7 +744,7 @@ static int gpmc_nand_probe(struct device_d *pdev)
* until you get a failure or success
*/
if (pdata->wait_mon_pin > 4) {
- gpmcnand_err("Invalid wait monitoring pin\n");
+ dev_dbg(pdev, "Invalid wait monitoring pin\n");
err = -EINVAL;
goto out_release_mem;
}
@@ -774,7 +774,7 @@ static int gpmc_nand_probe(struct device_d *pdev)
if (pdata->nand_setup) {
err = pdata->nand_setup(pdata);
if (err) {
- gpmcnand_err("pdataform setup failed\n");
+ dev_dbg(pdev, "pdataform setup failed\n");
goto out_release_mem;
}
}
@@ -826,7 +826,7 @@ static int gpmc_nand_probe(struct device_d *pdev)
/* We are all set to register with the system now! */
err = add_mtd_device(minfo);
if (err) {
- gpmcnand_err("device registration failed\n");
+ dev_dbg(pdev, "device registration failed\n");
goto out_release_mem;
}
@@ -838,7 +838,7 @@ out_release_mem:
if (oinfo)
free(oinfo);
- gpmcnand_err("Failed!!\n");
+ dev_dbg(pdev, "Failed!!\n");
return err;
}
--
1.7.2.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-04-11 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 14:10 omap nand patches Sascha Hauer
2011-04-11 14:10 ` [PATCH 1/5] nand omap: fix hamming romcode ecc code Sascha Hauer
2011-04-11 14:10 ` Sascha Hauer [this message]
2011-04-11 14:10 ` [PATCH 3/5] nand omap: use standard debug functions Sascha Hauer
2011-04-11 14:10 ` [PATCH 4/5] nand omap: use xzalloc instead of calloc Sascha Hauer
2011-04-11 14:10 ` [PATCH 5/5] nand omap: handle erased pages correctly in hamming ecc mode Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302531036-27906-3-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox