From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: [PATCH v2] complete: add var and device param complete support
Date: Fri, 10 Jun 2011 03:29:27 +0200 [thread overview]
Message-ID: <1307669367-3129-1-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <1307631354-5553-1-git-send-email-plagnioj@jcrosoft.com>
with $xx or xx= or if device $xx.yy or xx.yy=
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
v2:
make the call device_param_complete safe
Best Regards,
J.
common/complete.c | 112 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 111 insertions(+), 1 deletions(-)
diff --git a/common/complete.c b/common/complete.c
index 46ba871..5f1df74 100644
--- a/common/complete.c
+++ b/common/complete.c
@@ -27,6 +27,7 @@
#include <libgen.h>
#include <command.h>
#include <stringlist.h>
+#include <environment.h>
static int file_complete(struct string_list *sl, char *instr)
{
@@ -84,6 +85,111 @@ static int command_complete(struct string_list *sl, char *instr)
return 0;
}
+static int device_param_complete(char begin, struct device_d *dev,
+ struct string_list *sl, char *instr)
+{
+ struct param_d *param;
+ char cmd[128];
+ char *tmp = cmd;
+ int len, len2;
+
+ len = strlen(instr);
+ if (begin) {
+ tmp[0] = begin;
+ tmp++;
+ }
+ strcpy(tmp, dev_name(dev));
+ len2 = strlen(dev_name(dev));
+ tmp += len2;
+ tmp[0] = '.';
+ tmp++;
+
+ list_for_each_entry(param, &dev->parameters, list) {
+ memset(tmp, 0x0, 128 - (int)(tmp - cmd));
+ if (!strncmp(instr, param->name, len)) {
+ strcpy(tmp, param->name);
+ len2 = strlen(param->name);
+ if (begin)
+ tmp[len2] = ' ';
+ else
+ tmp[len2] = '=';
+ tmp[len2 + 1] = 0;
+ string_list_add(sl, cmd);
+ }
+ }
+
+ return 0;
+}
+
+static int env_param_complete(struct string_list *sl, char *instr, int eval)
+{
+ struct device_d *dev;
+ struct variable_d *var;
+ struct env_context *c, *current_c;
+ char cmd[128];
+ char *instr_param;
+ char *tmp = cmd;
+ int len, len2;
+ char end = '=';
+
+ if (eval) {
+ cmd[0] = '$';
+ tmp++;
+ end = ' ';
+ }
+
+ instr_param = strrchr(instr, '.');
+ len = strlen(instr);
+
+ current_c = get_current_context();
+ var = current_c->local->next;
+ while (var) {
+ if (!strncmp(instr, var_name(var), len)) {
+ len2 = strlen(var_name(var));
+ strcpy(tmp, var_name(var));
+ tmp[len2] = end;
+ tmp[len2 + 1] = 0;
+ string_list_add(sl, cmd);
+ }
+ var = var->next;
+ }
+
+ c = get_current_context();
+ while(c) {
+ var = c->global->next;
+ while (var) {
+ if (!strncmp(instr, var_name(var), len)) {
+ len2 = strlen(var_name(var));
+ strcpy(tmp, var_name(var));
+ tmp[len2] = end;
+ tmp[len2 + 1] = 0;
+ string_list_add(sl, cmd);
+ }
+ var = var->next;
+ }
+ c = c->parent;
+ }
+
+ if (instr_param) {
+ len = (instr_param - instr);
+ instr_param++;
+ } else {
+ len = strlen(instr);
+ instr_param = "";
+ }
+
+ for_each_device(dev) {
+ if (!strncmp(instr, dev_name(dev), len)) {
+ if (eval)
+ device_param_complete('$', dev, sl, instr_param);
+ else
+ device_param_complete(0, dev, sl, instr_param);
+ }
+ }
+
+ return 0;
+}
+
static int tab_pressed = 0;
void complete_reset(void)
@@ -121,8 +227,12 @@ int complete(char *instr, char **outstr)
t++;
file_complete(&sl, t);
instr = t;
- } else
+ } else {
command_complete(&sl, instr);
+ env_param_complete(&sl, instr, 0);
+ }
+ if (*instr == '$')
+ env_param_complete(&sl, instr + 1, 1);
pos = strlen(instr);
--
1.7.4.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2011-06-10 1:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 14:50 pull request " Jean-Christophe PLAGNIOL-VILLARD
2011-06-09 14:55 ` [PATCH 1/6] complete: add var and device param " Jean-Christophe PLAGNIOL-VILLARD
2011-06-10 1:29 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-06-10 6:53 ` [PATCH v2] " Sascha Hauer
2011-06-10 7:03 ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-10 8:00 ` Sascha Hauer
2011-06-09 14:55 ` [PATCH 2/6] complete: add generic command complete framework Jean-Christophe PLAGNIOL-VILLARD
2011-06-09 14:55 ` [PATCH 3/6] complete: add device name complete support for devinfo Jean-Christophe PLAGNIOL-VILLARD
2011-06-09 14:55 ` [PATCH 4/6] complete: add help complete support Jean-Christophe PLAGNIOL-VILLARD
2011-06-09 14:55 ` [PATCH 5/6] complete: add empty " Jean-Christophe PLAGNIOL-VILLARD
2011-06-09 14:55 ` [PATCH 6/6] complete: add eth interface " Jean-Christophe PLAGNIOL-VILLARD
2011-06-09 22:46 ` pull request " Hubert Feurstein
2011-06-10 1:25 ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-10 1:30 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307669367-3129-1-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox