[PATCH] macb: add support for board specific get_ethaddr function

[PATCH] macb: add support for board specific get_ethaddr function

[Hubert Feurstein]

Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 arch/arm/mach-at91/include/mach/board.h |    2 ++
 drivers/net/macb.c                      |    2 +-
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-at91/include/mach/board.h b/arch/arm/mach-at91/include/mach/board.h
index 89c1746..89caebb 100644
--- a/arch/arm/mach-at91/include/mach/board.h
+++ b/arch/arm/mach-at91/include/mach/board.h
@@ -21,6 +21,7 @@
 #ifndef __ASM_ARCH_BOARD_H
 #define __ASM_ARCH_BOARD_H

+#include <net.h>
 #include <linux/mtd/mtd.h>

 void atmel_nand_load_image(void *dest, int size, int pagesize, int blocksize);
@@ -47,6 +48,7 @@ void at91_add_device_nand(struct atmel_nand_data *data);
 struct at91_ether_platform_data {
 	unsigned int flags;
 	int phy_addr;
+	int (*get_ethaddr)(struct eth_device*, unsigned char *adr);
 };

 void at91_add_device_eth(struct at91_ether_platform_data *data);
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index df3b6af..bc6618b 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -431,7 +431,7 @@ static int macb_probe(struct device_d *dev)
 	edev->send = macb_send;
 	edev->recv = macb_recv;
 	edev->halt = macb_halt;
-	edev->get_ethaddr = macb_get_ethaddr;
+	edev->get_ethaddr = pdata->get_ethaddr ? pdata->get_ethaddr : macb_get_ethaddr;
 	edev->set_ethaddr = macb_set_ethaddr;

 	macb->miidev.read = macb_phy_read;
--
1.7.4.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] macb: add support for board specific get_ethaddr function

[Jean-Christophe PLAGNIOL-VILLARD]

On 15:55 Thu 16 Jun     , Hubert Feurstein wrote:
> Signed-off-by: Hubert Feurstein <h.feurstein@gmail.com>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/mach-at91/include/mach/board.h |    2 ++
>  drivers/net/macb.c                      |    2 +-
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/include/mach/board.h b/arch/arm/mach-at91/include/mach/board.h
> index 89c1746..89caebb 100644
> --- a/arch/arm/mach-at91/include/mach/board.h
> +++ b/arch/arm/mach-at91/include/mach/board.h
> @@ -21,6 +21,7 @@
>  #ifndef __ASM_ARCH_BOARD_H
>  #define __ASM_ARCH_BOARD_H
> 
> +#include <net.h>
>  #include <linux/mtd/mtd.h>
> 
>  void atmel_nand_load_image(void *dest, int size, int pagesize, int blocksize);
> @@ -47,6 +48,7 @@ void at91_add_device_nand(struct atmel_nand_data *data);
>  struct at91_ether_platform_data {
>  	unsigned int flags;
>  	int phy_addr;
> +	int (*get_ethaddr)(struct eth_device*, unsigned char *adr);
can we find a generic way?

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] macb: add support for board specific get_ethaddr function

[Hubert Feurstein]

2011/6/21 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
>> @@ -47,6 +48,7 @@ void at91_add_device_nand(struct atmel_nand_data *data);
>>  struct at91_ether_platform_data {
>>       unsigned int flags;
>>       int phy_addr;
>> +     int (*get_ethaddr)(struct eth_device*, unsigned char *adr);
> can we find a generic way?
a generic way would be to simply call
'dev_set_param(get_device_by_name("eth0"), "ethaddr", macbuffer)'
somewhere after at91_add_device_eth(...) in your init. Then you don't
need the callback at all to setup the mac-address.

Best Regards
Hubert

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] macb: add support for board specific get_ethaddr function

[Jean-Christophe PLAGNIOL-VILLARD]

On 23:51 Tue 21 Jun     , Hubert Feurstein wrote:
> 2011/6/21 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
> >> @@ -47,6 +48,7 @@ void at91_add_device_nand(struct atmel_nand_data *data);
> >>  struct at91_ether_platform_data {
> >>       unsigned int flags;
> >>       int phy_addr;
> >> +     int (*get_ethaddr)(struct eth_device*, unsigned char *adr);
> > can we find a generic way?
> a generic way would be to simply call
> 'dev_set_param(get_device_by_name("eth0"), "ethaddr", macbuffer)'
> somewhere after at91_add_device_eth(...) in your init. Then you don't
> need the callback at all to setup the mac-address.
I more in mind an api to update the get/set_ethaddr without specific hookin
each driver

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox