mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH] commands/led.c: fix return codes
Date: Tue,  2 Aug 2011 11:08:08 +0400	[thread overview]
Message-ID: <1312268888-16657-1-git-send-email-antonynpavlov@gmail.com> (raw)

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 commands/led.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/commands/led.c b/commands/led.c
index 360ce7c..afb3fd3 100644
--- a/commands/led.c
+++ b/commands/led.c
@@ -45,7 +45,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 					led->max_value);
 			i++;
 		}
-		return 0;
+		return COMMAND_SUCCESS;
 	}
 
 	if (argc != 3)
@@ -54,7 +54,7 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 	led = led_by_name_or_number(argv[1]);
 	if (!led) {
 		printf("no such LED: %s\n", argv[1]);
-		return 1;
+		return COMMAND_ERROR;
 	}
 
 	value = simple_strtoul(argv[optind + 1], NULL, 0);
@@ -62,10 +62,10 @@ static int do_led(struct command *cmdtp, int argc, char *argv[])
 	ret = led_set(led, value);
 	if (ret < 0) {
 		perror("led");
-		return 1;
+		return COMMAND_ERROR;
 	}
 
-	return 0;
+	return COMMAND_SUCCESS;
 }
 
 /**
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2011-08-02  7:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02  7:08 Antony Pavlov [this message]
2011-08-03  7:29 ` Sascha Hauer
2011-08-03  8:33   ` [PATCH] commands/led.c: fix return code Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312268888-16657-1-git-send-email-antonynpavlov@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox