mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/8] ARM: add missing volatile in get_cr()
Date: Mon,  8 Aug 2011 08:46:36 +0200	[thread overview]
Message-ID: <1312786003-14734-2-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1312786003-14734-1-git-send-email-s.hauer@pengutronix.de>

Without it, the compiler optimizes away subsequent reads of the
control register.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm/include/asm/system.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
index 77d6305..1d67492 100644
--- a/arch/arm/include/asm/system.h
+++ b/arch/arm/include/asm/system.h
@@ -59,7 +59,7 @@
 static inline unsigned int get_cr(void)
 {
 	unsigned int val;
-	asm("mrc p15, 0, %0, c1, c0, 0  @ get CR" : "=r" (val) : : "cc");
+	asm volatile ("mrc p15, 0, %0, c1, c0, 0  @ get CR" : "=r" (val) : : "cc");
 	return val;
 }
 
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2011-08-08  6:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-08  6:46 ARM: use high vectors if possible Sascha Hauer
2011-08-08  6:46 ` Sascha Hauer [this message]
2011-08-08  6:46 ` [PATCH 2/8] ARM mmu: fix arm_create_pte Sascha Hauer
2011-08-08  6:46 ` [PATCH 3/8] ARM mmu: use high vectors if possible Sascha Hauer
2011-08-08  6:46 ` [PATCH 4/8] ARM: remove unused exception Sascha Hauer
2011-08-08  6:46 ` [PATCH 5/8] ARM: exceptions: remove unnecessary function declarations Sascha Hauer
2011-08-08  6:46 ` [PATCH 6/8] ARM: remove unused irq enable/disable functions Sascha Hauer
2011-08-08  6:46 ` [PATCH 7/8] ARM: fix comments in interrupts.c Sascha Hauer
2011-08-08  6:46 ` [PATCH 8/8] ARM: some cleanup " Sascha Hauer
2011-08-08  7:06 ` ARM: use high vectors if possible Jean-Christophe PLAGNIOL-VILLARD
2011-08-08  7:32   ` Sascha Hauer
2011-08-09  7:36     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312786003-14734-2-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox