mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] pcm memory fix
@ 2011-08-23 12:30 Tim Sander
  2011-08-23 13:06 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Tim Sander @ 2011-08-23 12:30 UTC (permalink / raw)
  To: barebox

This patch is inspired by ram_timing.patch from OSELAS.BSP-Phytec-phyCORE-i.MX35-PD10.1.2. 
PCM043 1315.6 does not boot without it.

Signed-off-by: Tim Sander <tim.sander@hbm.com>

    change refresh cycle

diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
index eff96f9..bbe586b 100644
--- a/arch/arm/boards/pcm043/lowlevel.c
+++ b/arch/arm/boards/pcm043/lowlevel.c
@@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
        writel(0x00000304, ESDMISC); /* was 0x00000004 */
 
        /* set timing paramters */
-       writel(0x00255417, ESDCFG0);
+       writel(0x0025541F, ESDCFG0);
        /* select Precharge-All mode */
        writel(0x92220000, ESDCTL0);
        /* Precharge-All */

Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 

Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster

Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster

The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.

Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pcm memory fix
  2011-08-23 12:30 [PATCH] pcm memory fix Tim Sander
@ 2011-08-23 13:06 ` Sascha Hauer
  2011-08-24  6:20   ` Teresa Gamez
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2011-08-23 13:06 UTC (permalink / raw)
  To: Tim Sander; +Cc: barebox

On Tue, Aug 23, 2011 at 02:30:01PM +0200, Tim Sander wrote:
> This patch is inspired by ram_timing.patch from OSELAS.BSP-Phytec-phyCORE-i.MX35-PD10.1.2. 
> PCM043 1315.6 does not boot without it.
> 
> Signed-off-by: Tim Sander <tim.sander@hbm.com>
> 
>     change refresh cycle

This is a duplicate of the patch Teresa recently sent. I just applied
Teresas version.

Sascha

> 
> diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
> index eff96f9..bbe586b 100644
> --- a/arch/arm/boards/pcm043/lowlevel.c
> +++ b/arch/arm/boards/pcm043/lowlevel.c
> @@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
>         writel(0x00000304, ESDMISC); /* was 0x00000004 */
>  
>         /* set timing paramters */
> -       writel(0x00255417, ESDCFG0);
> +       writel(0x0025541F, ESDCFG0);
>         /* select Precharge-All mode */
>         writel(0x92220000, ESDCTL0);
>         /* Precharge-All */
> 
> Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> 
> Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> 
> Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> 
> The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> 
> Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pcm memory fix
  2011-08-23 13:06 ` Sascha Hauer
@ 2011-08-24  6:20   ` Teresa Gamez
  2011-08-24  8:32     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Teresa Gamez @ 2011-08-24  6:20 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox, Tim Sander

Am Dienstag, den 23.08.2011, 15:06 +0200 schrieb Sascha Hauer:
> On Tue, Aug 23, 2011 at 02:30:01PM +0200, Tim Sander wrote:
> > This patch is inspired by ram_timing.patch from OSELAS.BSP-Phytec-phyCORE-i.MX35-PD10.1.2. 
> > PCM043 1315.6 does not boot without it.
> > 
> > Signed-off-by: Tim Sander <tim.sander@hbm.com>
> > 
> >     change refresh cycle
> 
> This is a duplicate of the patch Teresa recently sent. I just applied
> Teresas version.

Are there any reasons why you applied the first version of the patch and
not the second one with an updated description?

Teresa

> 
> Sascha
> 
> > 
> > diff --git a/arch/arm/boards/pcm043/lowlevel.c b/arch/arm/boards/pcm043/lowlevel.c
> > index eff96f9..bbe586b 100644
> > --- a/arch/arm/boards/pcm043/lowlevel.c
> > +++ b/arch/arm/boards/pcm043/lowlevel.c
> > @@ -146,7 +146,7 @@ void __bare_init __naked board_init_lowlevel(void)
> >         writel(0x00000304, ESDMISC); /* was 0x00000004 */
> >  
> >         /* set timing paramters */
> > -       writel(0x00255417, ESDCFG0);
> > +       writel(0x0025541F, ESDCFG0);
> >         /* select Precharge-All mode */
> >         writel(0x92220000, ESDCTL0);
> >         /* Precharge-All */
> > 
> > Hottinger Baldwin Messtechnik GmbH, Im Tiefen See 45, 64293 Darmstadt, Germany | www.hbm.com 
> > 
> > Registered as GmbH (German limited liability corporation) in the commercial register at the local court of Darmstadt, HRB 1147  
> > Company domiciled in Darmstadt | CEO: Andreas Huellhorst | Chairman of the board: James Charles Webster
> > 
> > Als Gesellschaft mit beschraenkter Haftung eingetragen im Handelsregister des Amtsgerichts Darmstadt unter HRB 1147 
> > Sitz der Gesellschaft: Darmstadt | Geschaeftsfuehrung: Andreas Huellhorst | Aufsichtsratsvorsitzender: James Charles Webster
> > 
> > The information in this email is confidential. It is intended solely for the addressee. If you are not the intended recipient, please let me know and delete this email.
> > 
> > Die in dieser E-Mail enthaltene Information ist vertraulich und lediglich fur den Empfaenger bestimmt. Sollten Sie nicht der eigentliche Empfaenger sein, informieren Sie mich bitte kurz und loeschen diese E-Mail.
> > 
> > 
> > _______________________________________________
> > barebox mailing list
> > barebox@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> > 
> 



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] pcm memory fix
  2011-08-24  6:20   ` Teresa Gamez
@ 2011-08-24  8:32     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2011-08-24  8:32 UTC (permalink / raw)
  To: Teresa Gamez; +Cc: barebox, Tim Sander

On Wed, Aug 24, 2011 at 08:20:18AM +0200, Teresa Gamez wrote:
> Am Dienstag, den 23.08.2011, 15:06 +0200 schrieb Sascha Hauer:
> > On Tue, Aug 23, 2011 at 02:30:01PM +0200, Tim Sander wrote:
> > > This patch is inspired by ram_timing.patch from OSELAS.BSP-Phytec-phyCORE-i.MX35-PD10.1.2. 
> > > PCM043 1315.6 does not boot without it.
> > > 
> > > Signed-off-by: Tim Sander <tim.sander@hbm.com>
> > > 
> > >     change refresh cycle
> > 
> > This is a duplicate of the patch Teresa recently sent. I just applied
> > Teresas version.
> 
> Are there any reasons why you applied the first version of the patch and
> not the second one with an updated description?

Damn, stupid me :(

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-08-24  8:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-23 12:30 [PATCH] pcm memory fix Tim Sander
2011-08-23 13:06 ` Sascha Hauer
2011-08-24  6:20   ` Teresa Gamez
2011-08-24  8:32     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox