From: Jan Weitzel <j.weitzel@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH v2] readkey: force return from while true
Date: Thu, 24 Nov 2011 11:48:54 +0100 [thread overview]
Message-ID: <1322131734-30864-1-git-send-email-j.weitzel@phytec.de> (raw)
In-Reply-To: <4ECE0C16.4040602@pengutronix.de>
If read_key is feeded by STRG + KEY_LEFT you run into the while(1)
loop and corrupt memory through esc array.
Force return if index gets too high.
Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
v2: use ARRAY_SIZE
lib/readkey.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/lib/readkey.c b/lib/readkey.c
index a42d1cb..1117c30 100644
--- a/lib/readkey.c
+++ b/lib/readkey.c
@@ -67,6 +67,8 @@ int read_key(void)
esc[i] = getc();
if (esc[i++] == '~')
break;
+ if (i == ARRAY_SIZE(esc))
+ return -1;
}
}
esc[i] = 0;
--
1.7.0.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2011-11-24 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 12:32 [PATCH] " Jan Weitzel
2011-11-22 20:20 ` Sascha Hauer
2011-11-24 9:19 ` Marc Kleine-Budde
2011-11-24 10:48 ` Jan Weitzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322131734-30864-1-git-send-email-j.weitzel@phytec.de \
--to=j.weitzel@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox