* [PATCH] crc exit with COMMAND_ERROR_USAGE
@ 2011-12-05 12:46 Jan Weitzel
0 siblings, 0 replies; only message in thread
From: Jan Weitzel @ 2011-12-05 12:46 UTC (permalink / raw)
To: barebox
If parameter -v without a crc is used, you got a notice but the crc is
calculated and exit status is 0.
With wrong parameters we should quite with COMMAND_ERROR_USAGE.
Signed-off-by: Jan Weitzel <j.weitzel@phytec.de>
---
commands/crc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/commands/crc.c b/commands/crc.c
index 01fedd7..8ce97da 100644
--- a/commands/crc.c
+++ b/commands/crc.c
@@ -108,6 +108,8 @@ static int do_crc(struct command *cmdtp, int argc, char *argv[])
verify = 1;
vcrc = simple_strtoul(optarg, NULL, 0);
break;
+ default:
+ return COMMAND_ERROR_USAGE;
}
}
--
1.7.0.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-12-05 12:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-05 12:46 [PATCH] crc exit with COMMAND_ERROR_USAGE Jan Weitzel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox