mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: barebox@lists.infradead.org
Subject: [PATCH] usb/gadget: add special treatment for PXA cpus
Date: Mon, 19 Dec 2011 10:17:17 +0100	[thread overview]
Message-ID: <1324286241-23083-1-git-send-email-robert.jarzmik@free.fr> (raw)

As PXA cpus suffer from a silicon bug which prevents them
from being compound devices, forbid use_acm=1 for PXAs.
---
 drivers/usb/gadget/serial.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c
index f6a712b..8ba9ab5 100644
--- a/drivers/usb/gadget/serial.c
+++ b/drivers/usb/gadget/serial.c
@@ -179,6 +179,14 @@ static int __init gserial_init(void)
 	/* We *could* export two configs; that'd be much cleaner...
 	 * but neither of these product IDs was defined that way.
 	 */
+
+	/*
+	 * PXA CPU suffer a silicon bug which prevents them from being a
+	 * compound device, forbiding the ACM configurations.
+	 */
+#ifdef CONFIG_ARCH_PXA2XX
+	use_acm = 0;
+#endif
 	if (use_acm) {
 		serial_config_driver.label = "CDC ACM config";
 		serial_config_driver.bConfigurationValue = 2;
@@ -204,4 +212,3 @@ static int __init gserial_init(void)
 }
 
 late_initcall(gserial_init);
-
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2011-12-19  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19  9:17 Robert Jarzmik [this message]
2011-12-19  9:17 ` [PATCH] drivers/mci: pxa writedata timeout Robert Jarzmik
2011-12-19  9:17 ` [PATCH] drivers/mci: pxa read data performance boost Robert Jarzmik
2011-12-19  9:17 ` [PATCH] commands: add hexdump command Robert Jarzmik
2011-12-19 11:29   ` Antony Pavlov
2011-12-19 12:15     ` Robert Jarzmik
2011-12-19  9:17 ` [PATCH] arch/arm: mmu: add map_io_range() Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324286241-23083-1-git-send-email-robert.jarzmik@free.fr \
    --to=robert.jarzmik@free.fr \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox