* [PATCH] command: flash: remove broken filename check
@ 2011-12-21 14:56 Wolfram Sang
0 siblings, 0 replies; only message in thread
From: Wolfram Sang @ 2011-12-21 14:56 UTC (permalink / raw)
To: barebox
It makes no sense to check the filename pointer here, because a) we have
already been using it and b) argc has been tested against 1 already, so
argv[1] should not be NULL. So, drop the checks.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
commands/flash.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/commands/flash.c b/commands/flash.c
index db7c87d..8237ac8 100644
--- a/commands/flash.c
+++ b/commands/flash.c
@@ -58,11 +58,6 @@ static int do_flerase(struct command *cmdtp, int argc, char *argv[])
size = s.st_size;
- if (!filename) {
- printf("missing filename\n");
- return 1;
- }
-
fd = open(filename, O_WRONLY);
if (fd < 0) {
printf("open %s: %s", filename, errno_str());
@@ -136,11 +131,6 @@ static int do_protect(struct command *cmdtp, int argc, char *argv[])
size = s.st_size;
- if (!filename) {
- printf("missing filename\n");
- return 1;
- }
-
fd = open(filename, O_WRONLY);
if (fd < 0) {
printf("open %s: %s", filename, errno_str());
--
1.7.7.3
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-12-21 14:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 14:56 [PATCH] command: flash: remove broken filename check Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox