[RFC] Select CMD_LOADENV with DEFAULT_ENVIRONMENT

[RFC] Select CMD_LOADENV with DEFAULT_ENVIRONMENT

[Sanjeev Premi]

The environment isn't loaded until this command is
is selected - even if compiled in.

This patch makes the dependency explicit.

Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 Problem was encountered when trying to boot Linux with
 default environmenti on OMAP3 EVM. Since the default
 config was also being improved from its current state,
 it took rather long to narrow why the compiled
 environment was being 'ignored'.

 Sending change as RFC, as I may be missing something
 obvious as well.

 common/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/common/Kconfig b/common/Kconfig
index d1db27d..2a7cbfc 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -447,6 +447,7 @@ config PARTITION_DISK_DOS
 config DEFAULT_ENVIRONMENT
 	bool
 	default y
+	select CMD_LOADENV
 	prompt "Compile in default environment"
 	help
 	  Enabling this option will give you a default environment when
-- 
1.7.0.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [RFC] Select CMD_LOADENV with DEFAULT_ENVIRONMENT

[Sascha Hauer]

On Tue, Feb 07, 2012 at 10:22:45PM +0530, Sanjeev Premi wrote:
> The environment isn't loaded until this command is
> is selected - even if compiled in.
> 
> This patch makes the dependency explicit.
> 
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
>  Problem was encountered when trying to boot Linux with
>  default environmenti on OMAP3 EVM. Since the default
>  config was also being improved from its current state,
>  it took rather long to narrow why the compiled
>  environment was being 'ignored'.

Nice catch. Applied to master.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox