From: Robert Jarzmik <robert.jarzmik@free.fr>
To: barebox@lists.infradead.org
Subject: [PATCH V3 3/3] drivers/video: remove pxafb enable on load
Date: Thu, 16 Feb 2012 19:23:48 +0100 [thread overview]
Message-ID: <1329416628-19781-3-git-send-email-robert.jarzmik@free.fr> (raw)
In-Reply-To: <1329416628-19781-1-git-send-email-robert.jarzmik@free.fr>
As pxafb can rely on a PWM to control backlight, and because
driver dependencies are hard to deal with, remove automatic
enable of PXAFB on probe.
The user should in its environment do a :
- fb0.enable=1
This way, the PWM has been probed and is ready to work, and
the pxafb backlight control works.
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
arch/arm/mach-pxa/include/mach/pxafb.h | 1 -
drivers/video/pxa.c | 3 ---
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-pxa/include/mach/pxafb.h b/arch/arm/mach-pxa/include/mach/pxafb.h
index 1730fbf..23cbea9 100644
--- a/arch/arm/mach-pxa/include/mach/pxafb.h
+++ b/arch/arm/mach-pxa/include/mach/pxafb.h
@@ -64,7 +64,6 @@ struct pxafb_videomode {
struct pxafb_platform_data {
struct pxafb_videomode *mode;
unsigned int lcd_conn;
- int enable_on_load;
/** force a memory area to be used, else NULL for dynamic allocation */
void *framebuffer;
diff --git a/drivers/video/pxa.c b/drivers/video/pxa.c
index ddd7087..900ae80 100644
--- a/drivers/video/pxa.c
+++ b/drivers/video/pxa.c
@@ -538,9 +538,6 @@ static int pxafb_probe(struct device_d *dev)
return ret;
}
- if (pdata->enable_on_load)
- info->fbops->fb_enable(info);
-
return 0;
}
--
1.7.5.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2012-02-16 18:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-31 9:36 [PATCH] Add pwm core support Sascha Hauer
2012-02-01 8:20 ` Robert Jarzmik
2012-02-01 22:42 ` [PATCH] drivers/pwm: add PXA pulse width modulator controller Robert Jarzmik
2012-02-03 9:52 ` Sascha Hauer
2012-02-03 15:39 ` Robert Jarzmik
2012-02-08 15:26 ` Robert Jarzmik
2012-02-09 8:10 ` Sascha Hauer
2012-02-09 11:50 ` Robert Jarzmik
2012-02-09 13:44 ` Sascha Hauer
2012-02-09 14:30 ` Robert Jarzmik
2012-02-14 12:58 ` [PATCH V2 1/2] " Robert Jarzmik
2012-02-14 12:58 ` [PATCH V2 2/2] drivers/video: remove pxafb enable on load Robert Jarzmik
2012-02-15 8:32 ` [PATCH V2 1/2] drivers/pwm: add PXA pulse width modulator controller Sascha Hauer
2012-02-15 11:22 ` Robert Jarzmik
2012-02-15 15:21 ` Robert Jarzmik
2012-02-16 7:40 ` Sascha Hauer
2012-02-16 18:23 ` [PATCH V3 1/3] drivers/pwm: add duty_ns and period_ns to core pwm chip Robert Jarzmik
2012-02-16 18:23 ` [PATCH V3 2/3] drivers/pwm: add PXA pulse width modulator controller Robert Jarzmik
2012-02-16 18:23 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329416628-19781-3-git-send-email-robert.jarzmik@free.fr \
--to=robert.jarzmik@free.fr \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox