* [PATCH] cp: fix memory leak
@ 2012-02-27 8:37 Sascha Hauer
0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2012-02-27 8:37 UTC (permalink / raw)
To: barebox
dst is an allocated string, we have to free it also when
copy_file fails.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/cp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/commands/cp.c b/commands/cp.c
index f78e3de..565eca0 100644
--- a/commands/cp.c
+++ b/commands/cp.c
@@ -77,9 +77,9 @@ static int do_cp(struct command *cmdtp, int argc, char *argv[])
char *dst;
dst = concat_path_file(argv[argc - 1], basename(argv[i]));
ret = copy_file(argv[i], dst, verbose);
+ free(dst);
if (ret)
goto out;
- free(dst);
} else {
ret = copy_file(argv[i], argv[argc - 1], verbose);
if (ret)
--
1.7.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-02-27 8:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-27 8:37 [PATCH] cp: fix memory leak Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox