From: Christian Eggers <ceggers@arri.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: <barebox@lists.infradead.org>
Subject: FIT: support for compressed images breaks existing images
Date: Fri, 25 Aug 2023 11:44:04 +0200 [thread overview]
Message-ID: <13356260.uLZWGnKmhe@n95hx1g2> (raw)
Hi Ahmad,
On Wednesday, 23 August 2023, 18:32:06 CEST, Ahmad Fatoum wrote:
> I need not tell you though that latest is greatest and all that ;)
after rebasing my internal branch to v2023.8.0, my system doesn't
boot anymore:
Booting entry '/dev/nand0.root.ubi.kernel0'
FIT: Opened FIT image: Barebox fitImage for Poky (Yocto Project Reference Distro)/1.0/orbiter
FIT: matching unit 'conf-imx6ull-arri-orbiter-revB.dtb' found
FIT: configuration 'conf-imx6ull-arri-orbiter-revB.dtb': 7 Linux kernel, FDT blob, ramdisk
FIT: image 'kernel-1': 'Linux kernel'
FIT: /images/kernel-1/hash-1: hash OK
Loading open firmware Device Tree flattened Binary '/dev/nand0.root.ubi.kernel0'
FIT: image 'ramdisk-1': 'lios-initramfs-ubifs-orbiter.cpio.lz4'
FIT: /images/ramdisk-1/hash-1: hash OK
cannot handle filetype LZ4 compressed
ERROR: FIT: data couldn't be decompressed
ERROR: Cannot open ramdisk image in FIT image: Function not implemented
ERROR: Booting entry '/dev/nand0.root.ubi.kernel0' failed
Since commit
2ab6780b80e3 ("FIT: add first support for compressed images")
Barebox uses the "compression" key from the FIT image which breaks loading my
ramdisk (LZ4 compressed, should be decompressed by the kernel). Although the
compression parameter should be "none" in that case, it actually isn't. Older
Yocto releases used to set the actual compression type here:
https://git.yoctoproject.org/poky/commit/?h=kirkstone&id=2c58079222310443f08df51e9fd6ce234e7e0019
In U-Boot, the "compression" parameter is ignored for ramdisks due to this
problem. Only a warning is printed:
https://source.denx.de/u-boot/u-boot/-/commit/bddd98573465
https://source.denx.de/u-boot/u-boot/-/blob/master/boot/image-fit.c#L2289
Could you also apply this workaround to Barebox?
regards,
Christian
next reply other threads:[~2023-08-25 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 9:44 Christian Eggers [this message]
2023-08-25 10:23 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13356260.uLZWGnKmhe@n95hx1g2 \
--to=ceggers@arri.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox