From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp12.mail.ru ([94.100.176.89]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SSwDv-0004a8-QC for barebox@lists.infradead.org; Fri, 11 May 2012 20:14:01 +0000 From: Alexander Shiyan Date: Sat, 12 May 2012 00:17:07 +0400 Message-Id: <1336767428-21412-1-git-send-email-shc_work@mail.ru> In-Reply-To: <20120511200205.GT27341@pengutronix.de> References: <20120511200205.GT27341@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH 1/2] i2c: Fix barebox crash when 'count' is not set for i2c_read command To: barebox@lists.infradead.org Running i2c_read without the 'count' setting causes an error and reboots. barebox@Phytec phyCORE-i.MX27:/ i2c_read -b 1 -a 0x4a -r 0x00 ERROR: out of memory no stack data available Signed-off-by: Alexander Shiyan --- commands/i2c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/commands/i2c.c b/commands/i2c.c index b3d09dc..39bae35 100644 --- a/commands/i2c.c +++ b/commands/i2c.c @@ -170,7 +170,7 @@ static int do_i2c_read(int argc, char *argv[]) } } - if ((addr < 0) || (reg < 0) || (count == 0) || (addr > 0x7F)) + if ((addr < 0) || (reg < 0) || (count < 1) || (addr > 0x7F)) return COMMAND_ERROR_USAGE; adapter = i2c_get_adapter(bus); -- 1.7.3.4 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox