* [PATCH] i.MX25: fix eSDHC1 pads
@ 2012-05-24 20:05 Eric Bénard
2012-05-24 20:25 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Eric Bénard @ 2012-05-24 20:05 UTC (permalink / raw)
To: barebox
enabling SION bit makes SDHC1 working on the i.MX25.
tested on cpuimx25 board :
barebox@Eukrea CPUIMX25:/ mci0.probe=1
mci@mci0: registered disk0
barebox@Eukrea CPUIMX25:/ mkdir /mnt
barebox@Eukrea CPUIMX25:/ mount /dev/disk0.0 fat /mnt/
barebox@Eukrea CPUIMX25:/ devinfo mci0
resources:
driver: mci
Card:
Attached is an SD Card (Version: 2.0)
Capacity: 3826 MiB
High capacity card
CID: 1B534D30-30303030-107EA01B-4700AC00
CSD: 400E0032-5B590000-1DE37F80-0A404000
Max. transfer speed: 25000000 Hz
Manufacturer ID: 1B
OEM/Application ID: 534D
Product name: '00000'
Product revision: 1.0
Serial no: 2124421959
Manufacturing date: 12.2010
Parameters:
probe = 1
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
arch/arm/mach-imx/include/mach/iomux-mx25.h | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-imx/include/mach/iomux-mx25.h b/arch/arm/mach-imx/include/mach/iomux-mx25.h
index 58761b5..5010816 100644
--- a/arch/arm/mach-imx/include/mach/iomux-mx25.h
+++ b/arch/arm/mach-imx/include/mach/iomux-mx25.h
@@ -361,26 +361,26 @@
#define MX25_PAD_UART2_CTS__UART2_CTS IOMUX_PAD(0x384, 0x18c, 0x00, 0, 0, NO_PAD_CTRL)
#define MX25_PAD_UART2_CTS__GPIO_4_29 IOMUX_PAD(0x384, 0x18c, 0x05, 0, 0, NO_PAD_CTRL)
-#define MX25_PAD_SD1_CMD__SD1_CMD IOMUX_PAD(0x388, 0x190, 0x00, 0, 0, PAD_CTL_PUS_47K_UP)
+#define MX25_PAD_SD1_CMD__SD1_CMD IOMUX_PAD(0x388, 0x190, 0x10, 0, 0, PAD_CTL_PUS_47K_UP)
#define MX25_PAD_SD1_CMD__FEC_RDATA2 IOMUX_PAD(0x388, 0x190, 0x02, 0x50c, 2, NO_PAD_CTRL)
#define MX25_PAD_SD1_CMD__GPIO_2_23 IOMUX_PAD(0x388, 0x190, 0x05, 0, 0, NO_PAD_CTRL)
-#define MX25_PAD_SD1_CLK__SD1_CLK IOMUX_PAD(0x38c, 0x194, 0x00, 0, 0, PAD_CTL_PUS_47K_UP)
+#define MX25_PAD_SD1_CLK__SD1_CLK IOMUX_PAD(0x38c, 0x194, 0x10, 0, 0, PAD_CTL_PUS_47K_UP)
#define MX25_PAD_SD1_CLK__FEC_RDATA3 IOMUX_PAD(0x38c, 0x194, 0x02, 0x510, 2, NO_PAD_CTRL)
#define MX25_PAD_SD1_CLK__GPIO_2_24 IOMUX_PAD(0x38c, 0x194, 0x05, 0, 0, NO_PAD_CTRL)
-#define MX25_PAD_SD1_DATA0__SD1_DATA0 IOMUX_PAD(0x390, 0x198, 0x00, 0, 0, PAD_CTL_PUS_47K_UP)
+#define MX25_PAD_SD1_DATA0__SD1_DATA0 IOMUX_PAD(0x390, 0x198, 0x10, 0, 0, PAD_CTL_PUS_47K_UP)
#define MX25_PAD_SD1_DATA0__GPIO_2_25 IOMUX_PAD(0x390, 0x198, 0x05, 0, 0, NO_PAD_CTRL)
-#define MX25_PAD_SD1_DATA1__SD1_DATA1 IOMUX_PAD(0x394, 0x19c, 0x00, 0, 0, PAD_CTL_PUS_47K_UP)
+#define MX25_PAD_SD1_DATA1__SD1_DATA1 IOMUX_PAD(0x394, 0x19c, 0x10, 0, 0, PAD_CTL_PUS_47K_UP)
#define MX25_PAD_SD1_DATA1__AUD7_RXD IOMUX_PAD(0x394, 0x19c, 0x03, 0x478, 0, NO_PAD_CTRL)
#define MX25_PAD_SD1_DATA1__GPIO_2_26 IOMUX_PAD(0x394, 0x19c, 0x05, 0, 0, NO_PAD_CTRL)
-#define MX25_PAD_SD1_DATA2__SD1_DATA2 IOMUX_PAD(0x398, 0x1a0, 0x00, 0, 0, PAD_CTL_PUS_47K_UP)
+#define MX25_PAD_SD1_DATA2__SD1_DATA2 IOMUX_PAD(0x398, 0x1a0, 0x10, 0, 0, PAD_CTL_PUS_47K_UP)
#define MX25_PAD_SD1_DATA2__FEC_RX_CLK IOMUX_PAD(0x398, 0x1a0, 0x05, 0x514, 2, NO_PAD_CTRL)
#define MX25_PAD_SD1_DATA2__GPIO_2_27 IOMUX_PAD(0x398, 0x1a0, 0x05, 0, 0, NO_PAD_CTRL)
-#define MX25_PAD_SD1_DATA3__SD1_DATA3 IOMUX_PAD(0x39c, 0x1a4, 0x00, 0, 0, PAD_CTL_PUS_47K_UP)
+#define MX25_PAD_SD1_DATA3__SD1_DATA3 IOMUX_PAD(0x39c, 0x1a4, 0x10, 0, 0, PAD_CTL_PUS_47K_UP)
#define MX25_PAD_SD1_DATA3__FEC_CRS IOMUX_PAD(0x39c, 0x1a4, 0x00, 0x508, 2, NO_PAD_CTRL)
#define MX25_PAD_SD1_DATA3__GPIO_2_28 IOMUX_PAD(0x39c, 0x1a4, 0x05, 0, 0, NO_PAD_CTRL)
--
1.7.7.6
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] i.MX25: fix eSDHC1 pads
2012-05-24 20:05 [PATCH] i.MX25: fix eSDHC1 pads Eric Bénard
@ 2012-05-24 20:25 ` Sascha Hauer
2012-05-24 20:46 ` Eric Bénard
0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2012-05-24 20:25 UTC (permalink / raw)
To: Eric Bénard; +Cc: barebox
Hi Eric,
On Thu, May 24, 2012 at 10:05:03PM +0200, Eric Bénard wrote:
> enabling SION bit makes SDHC1 working on the i.MX25.
Can we instead just sync the iomux file with the kernel? I think this
will make less problems in the longer run. At least as long the iomux
files in the kernel still exist...
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i.MX25: fix eSDHC1 pads
2012-05-24 20:25 ` Sascha Hauer
@ 2012-05-24 20:46 ` Eric Bénard
2012-05-25 6:34 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Eric Bénard @ 2012-05-24 20:46 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
Hi Sascha,
Le Thu, 24 May 2012 22:25:10 +0200,
Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> On Thu, May 24, 2012 at 10:05:03PM +0200, Eric Bénard wrote:
> > enabling SION bit makes SDHC1 working on the i.MX25.
>
> Can we instead just sync the iomux file with the kernel? I think this
OK will post the patch syncing barebox & kernel.
> will make less problems in the longer run. At least as long the iomux
> files in the kernel still exist...
>
is iomux settings planned to be removed from the kernel ?
Eric
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i.MX25: fix eSDHC1 pads
2012-05-24 20:46 ` Eric Bénard
@ 2012-05-25 6:34 ` Sascha Hauer
2012-05-25 7:07 ` Roberto Nibali
0 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2012-05-25 6:34 UTC (permalink / raw)
To: Eric Bénard; +Cc: barebox
On Thu, May 24, 2012 at 10:46:40PM +0200, Eric Bénard wrote:
> Hi Sascha,
>
> Le Thu, 24 May 2012 22:25:10 +0200,
> Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> > On Thu, May 24, 2012 at 10:05:03PM +0200, Eric Bénard wrote:
> > > enabling SION bit makes SDHC1 working on the i.MX25.
> >
> > Can we instead just sync the iomux file with the kernel? I think this
>
> OK will post the patch syncing barebox & kernel.
>
> > will make less problems in the longer run. At least as long the iomux
> > files in the kernel still exist...
> >
> is iomux settings planned to be removed from the kernel ?
I suppose when all i.MX are converted to devicetree and pinmux they will
be removed. I don't know how long this will take though.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i.MX25: fix eSDHC1 pads
2012-05-25 6:34 ` Sascha Hauer
@ 2012-05-25 7:07 ` Roberto Nibali
2012-05-25 7:28 ` Sascha Hauer
0 siblings, 1 reply; 6+ messages in thread
From: Roberto Nibali @ 2012-05-25 7:07 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
[-- Attachment #1.1: Type: text/plain, Size: 1363 bytes --]
On Fri, May 25, 2012 at 8:34 AM, Sascha Hauer <s.hauer@pengutronix.de>wrote:
> On Thu, May 24, 2012 at 10:46:40PM +0200, Eric Bénard wrote:
> > Hi Sascha,
> >
> > Le Thu, 24 May 2012 22:25:10 +0200,
> > Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> > > On Thu, May 24, 2012 at 10:05:03PM +0200, Eric Bénard wrote:
> > > > enabling SION bit makes SDHC1 working on the i.MX25.
>
I am a bit surprised since in my case, SDHC1 worked out of the box, after
disabling all the iomux pad configuration settings. I believe sync'ing the
iomux with the kernel goes both with the philosophy of barebox and its
maintainability.
> > > Can we instead just sync the iomux file with the kernel? I think this
> >
> > OK will post the patch syncing barebox & kernel.
> >
> > > will make less problems in the longer run. At least as long the iomux
> > > files in the kernel still exist...
> > >
> > is iomux settings planned to be removed from the kernel ?
>
> I suppose when all i.MX are converted to devicetree and pinmux they will
> be removed. I don't know how long this will take though.
>
>
Has anybody started on the mx25 conversion to devicetree and pinmux yet?
Last time I checked at lot of other fsl cores had already been converted,
but not this one. Eric, have you tried moving to your mx25 to device tree
yet?
Cheers
Roberto
[-- Attachment #1.2: Type: text/html, Size: 2038 bytes --]
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i.MX25: fix eSDHC1 pads
2012-05-25 7:07 ` Roberto Nibali
@ 2012-05-25 7:28 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2012-05-25 7:28 UTC (permalink / raw)
To: Roberto Nibali; +Cc: barebox
On Fri, May 25, 2012 at 09:07:24AM +0200, Roberto Nibali wrote:
> On Fri, May 25, 2012 at 8:34 AM, Sascha Hauer <s.hauer@pengutronix.de>wrote:
>
> > On Thu, May 24, 2012 at 10:46:40PM +0200, Eric Bénard wrote:
> > > Hi Sascha,
> > >
> > > Le Thu, 24 May 2012 22:25:10 +0200,
> > > Sascha Hauer <s.hauer@pengutronix.de> a écrit :
> > > > On Thu, May 24, 2012 at 10:05:03PM +0200, Eric Bénard wrote:
> > > > > enabling SION bit makes SDHC1 working on the i.MX25.
> >
>
> I am a bit surprised since in my case, SDHC1 worked out of the box, after
> disabling all the iomux pad configuration settings. I believe sync'ing the
> iomux with the kernel goes both with the philosophy of barebox and its
> maintainability.
>
>
> > > > Can we instead just sync the iomux file with the kernel? I think this
> > >
> > > OK will post the patch syncing barebox & kernel.
> > >
> > > > will make less problems in the longer run. At least as long the iomux
> > > > files in the kernel still exist...
> > > >
> > > is iomux settings planned to be removed from the kernel ?
> >
> > I suppose when all i.MX are converted to devicetree and pinmux they will
> > be removed. I don't know how long this will take though.
> >
> >
> Has anybody started on the mx25 conversion to devicetree and pinmux yet?
> Last time I checked at lot of other fsl cores had already been converted,
> but not this one. Eric, have you tried moving to your mx25 to device tree
> yet?
I ported over the i.MX27 to devicetree (no pinmux though) and it turned
out to be a fairly easy task, at least for the devices which are
supported already due to the i.MX5/6 devicetree port.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-25 7:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-24 20:05 [PATCH] i.MX25: fix eSDHC1 pads Eric Bénard
2012-05-24 20:25 ` Sascha Hauer
2012-05-24 20:46 ` Eric Bénard
2012-05-25 6:34 ` Sascha Hauer
2012-05-25 7:07 ` Roberto Nibali
2012-05-25 7:28 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox