From: Juergen Beisert <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH 1/2] Add a simple watchdog framework
Date: Wed, 27 Jun 2012 16:30:41 +0200 [thread overview]
Message-ID: <1340807442-5440-2-git-send-email-jbe@pengutronix.de> (raw)
In-Reply-To: <1340807442-5440-1-git-send-email-jbe@pengutronix.de>
This patch adds a simple wd command which can setup, trigger and stop a watchdog
on the platform.
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
---
commands/Kconfig | 19 +++++++++++++
commands/Makefile | 1 +
commands/wd.c | 68 ++++++++++++++++++++++++++++++++++++++++++++
drivers/Kconfig | 1 +
drivers/Makefile | 1 +
drivers/watchdog/Kconfig | 9 ++++++
drivers/watchdog/Makefile | 1 +
drivers/watchdog/wd_core.c | 61 +++++++++++++++++++++++++++++++++++++++
include/watchdog.h | 24 ++++++++++++++++
9 files changed, 185 insertions(+)
create mode 100644 commands/wd.c
create mode 100644 drivers/watchdog/Kconfig
create mode 100644 drivers/watchdog/Makefile
create mode 100644 drivers/watchdog/wd_core.c
create mode 100644 include/watchdog.h
diff --git a/commands/Kconfig b/commands/Kconfig
index 9fe0c57..2478e3f 100644
--- a/commands/Kconfig
+++ b/commands/Kconfig
@@ -579,6 +579,25 @@ config CMD_USB
help
The usb command allows to rescan for USB devices.
+menuconfig CMD_WD
+ bool
+ depends on WATCHDOG
+ prompt "wd command "
+ help
+ The 'wd' command which allows to start, stop and trigger the onboard
+ watchdog.
+
+if CMD_WD
+
+config CMD_WD_DEFAULT_TIMOUT
+ int
+ prompt "default timeout"
+ help
+ Define the default timeout value in [seconds] if the first call of
+ 'wd' is done without a timeout value (which means the watchdog gets
+ enabled and re-triggered with the default timeout value).
+endif
+
endmenu
endif
diff --git a/commands/Makefile b/commands/Makefile
index e9503da..54191b4 100644
--- a/commands/Makefile
+++ b/commands/Makefile
@@ -60,6 +60,7 @@ obj-$(CONFIG_CMD_MENU) += menu.o
obj-$(CONFIG_CMD_PASSWD) += passwd.o
obj-$(CONFIG_CMD_LOGIN) += login.o
obj-$(CONFIG_CMD_LED) += led.o
+obj-$(CONFIG_CMD_WD) += wd.o
obj-$(CONFIG_CMD_LED_TRIGGER) += trigger.o
obj-$(CONFIG_CMD_USB) += usb.o
obj-$(CONFIG_CMD_TIME) += time.o
diff --git a/commands/wd.c b/commands/wd.c
new file mode 100644
index 0000000..080bab9
--- /dev/null
+++ b/commands/wd.c
@@ -0,0 +1,68 @@
+/*
+ * (c) 2012 Juergen Beisert <kernel@pengutronix.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <common.h>
+#include <command.h>
+#include <errno.h>
+#include <linux/ctype.h>
+#include <watchdog.h>
+
+/* default timeout in [sec] */
+static unsigned timeout = CONFIG_CMD_WD_DEFAULT_TIMOUT;
+
+static int do_wd(int argc, char *argv[])
+{
+ int rc;
+
+ if (argc > 1) {
+ if (isdigit(*argv[1])) {
+ timeout = simple_strtoul(argv[1], NULL, 0);
+ } else {
+ printf("numerical parameter expected\n");
+ return 1;
+ }
+ }
+
+ rc = watchdog_set_timeout(timeout);
+ if (rc < 0) {
+ switch (rc) {
+ case -EINVAL:
+ printf("Timeout value out of range\n");
+ break;
+ case -ENOSYS:
+ printf("Watchdog cannot be disabled\n");
+ break;
+ default:
+ printf("Watchdog fails: '%s'\n", strerror(-rc));
+ break;
+ }
+
+ return 1;
+ }
+
+ return 0;
+}
+
+BAREBOX_CMD_HELP_START(wd)
+BAREBOX_CMD_HELP_USAGE("wd [<time>]\n")
+BAREBOX_CMD_HELP_SHORT("enable the watchdog to bark in <time> seconds. "
+ "When <time> is 0, the watchdog gets disabled,\n"
+ "without a parameter the watchdog will be re-triggered\n")
+BAREBOX_CMD_HELP_END
+
+BAREBOX_CMD_START(wd)
+ .cmd = do_wd,
+ .usage = "enable/disable/trigger the watchdog",
+ BAREBOX_CMD_HELP(cmd_wd_help)
+BAREBOX_CMD_END
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 037b0d4..e193063 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -18,5 +18,6 @@ source "drivers/input/Kconfig"
source "drivers/pwm/Kconfig"
source "drivers/dma/Kconfig"
+source "drivers/watchdog/Kconfig"
endmenu
diff --git a/drivers/Makefile b/drivers/Makefile
index f40b321..52a44c9 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -16,3 +16,4 @@ obj-y += eeprom/
obj-$(CONFIG_PWM) += pwm/
obj-y += input/
obj-y += dma/
+obj-y += watchdog/
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
new file mode 100644
index 0000000..c734dfe
--- /dev/null
+++ b/drivers/watchdog/Kconfig
@@ -0,0 +1,9 @@
+menuconfig WATCHDOG
+ bool "Watchdog support "
+ help
+ Many platforms support a watchdog to keep track of a working machine.
+ This framework provides routines to handle these watchdogs.
+
+if WATCHDOG
+
+endif
diff --git a/drivers/watchdog/Makefile b/drivers/watchdog/Makefile
new file mode 100644
index 0000000..630f1b6
--- /dev/null
+++ b/drivers/watchdog/Makefile
@@ -0,0 +1 @@
+obj-$(CONFIG_WATCHDOG) += wd_core.o
diff --git a/drivers/watchdog/wd_core.c b/drivers/watchdog/wd_core.c
new file mode 100644
index 0000000..8d22212
--- /dev/null
+++ b/drivers/watchdog/wd_core.c
@@ -0,0 +1,61 @@
+/*
+ * (c) 2012 Juergen Beisert <kernel@pengutronix.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <common.h>
+#include <command.h>
+#include <errno.h>
+#include <linux/ctype.h>
+#include <watchdog.h>
+
+/*
+ * Note: this simple framework supports one watchdog only.
+ */
+static struct watchdog *watchdog;
+
+int watchdog_register(struct watchdog *wd)
+{
+ if (wd == NULL)
+ return -EINVAL;
+ if (watchdog != NULL)
+ return -EBUSY;
+
+ watchdog = wd;
+ return 0;
+}
+EXPORT_SYMBOL(watchdog_register);
+
+int watchdog_deregister(struct watchdog *wd)
+{
+ if (wd == NULL)
+ return -EINVAL;
+ if (watchdog == NULL || wd != watchdog)
+ return -ENODEV;
+
+ watchdog = NULL;
+ return 0;
+}
+EXPORT_SYMBOL(watchdog_deregister);
+
+/*
+ * start, stop or retrigger the watchdog
+ * timeout in [seconds]. timeout of '0' will disable the watchdog (if possible)
+ */
+int watchdog_set_timeout(unsigned timeout)
+{
+ if (watchdog == NULL)
+ return -ENODEV;
+
+ return watchdog->set_timeout(watchdog, timeout);
+}
+EXPORT_SYMBOL(watchdog_set_timeout);
diff --git a/include/watchdog.h b/include/watchdog.h
new file mode 100644
index 0000000..3e2d08e
--- /dev/null
+++ b/include/watchdog.h
@@ -0,0 +1,24 @@
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef INCLUDE_WATCHDOG_H
+# define INCLUDE_WATCHDOG_H
+
+struct watchdog {
+ int (*set_timeout)(struct watchdog *, unsigned);
+};
+
+int watchdog_register(struct watchdog *);
+int watchdog_deregister(struct watchdog *);
+int watchdog_set_timeout(unsigned);
+
+#endif /* INCLUDE_WATCHDOG_H */
--
1.7.10
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-06-27 14:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 14:30 [PATCHv4] Add a simple watchdog 'framework' to Barebox Juergen Beisert
2012-06-27 14:30 ` Juergen Beisert [this message]
2012-06-27 14:30 ` [PATCH 2/2] ARM/MXS: add a watchdog driver for i.MX28 Juergen Beisert
-- strict thread matches above, loose matches on Subject: below --
2012-06-26 8:43 [PATCHv3] Add a simple watchdog 'framework' to Barebox Juergen Beisert
2012-06-26 8:43 ` [PATCH 1/2] Add a simple watchdog framework Juergen Beisert
2012-06-22 9:54 [PATCHv2] Add a simple watchdog 'framework' to Barebox Juergen Beisert
2012-06-22 9:54 ` [PATCH 1/2] Add a simple watchdog framework Juergen Beisert
2012-06-25 12:28 ` Sascha Hauer
2012-06-25 12:45 ` Juergen Beisert
2012-06-25 12:53 ` Sascha Hauer
2012-06-25 13:37 ` Juergen Beisert
2012-06-22 8:44 [PATCH] Add a simple watchdog 'framework' to Barebox Juergen Beisert
2012-06-22 8:44 ` [PATCH 1/2] Add a simple watchdog framework Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340807442-5440-2-git-send-email-jbe@pengutronix.de \
--to=jbe@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox