* [PATCH] mem md: bail out without arguments
@ 2012-07-05 7:14 Sascha Hauer
0 siblings, 0 replies; only message in thread
From: Sascha Hauer @ 2012-07-05 7:14 UTC (permalink / raw)
To: barebox; +Cc: rsc
Without arguments the 'md' command defaults to show address 0 which
likely results in a NULL pointer exception, so only three keystrokes
are necessary to crash barebox. Show usage instead if 'md' is invoked
without arguments, so that it at least requires an address to be given
to crash barebox. This increases the stability of barebox by 66%. Hurray!
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/mem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/commands/mem.c b/commands/mem.c
index c1a3a54..5322def 100644
--- a/commands/mem.c
+++ b/commands/mem.c
@@ -180,6 +180,8 @@ static int do_mem_md(int argc, char *argv[])
}
if (size == ~0)
size = 0x100;
+ } else {
+ return COMMAND_ERROR_USAGE;
}
fd = open_and_lseek(filename, mode | O_RDONLY, start);
--
1.7.10
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-05 7:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-05 7:14 [PATCH] mem md: bail out without arguments Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox