From: Franck Jullien <franck.jullien@gmail.com>
To: barebox@lists.infradead.org
Subject: [PATCH 2/2] fs/fat: Handle MBR on the first sector
Date: Sun, 16 Sep 2012 22:33:33 +0200 [thread overview]
Message-ID: <1347827613-25769-2-git-send-email-franck.jullien@gmail.com> (raw)
In-Reply-To: <1347827613-25769-1-git-send-email-franck.jullien@gmail.com>
Use the new filetype.c file detection function to support disk with MBR on the first
sector.
Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
---
fs/fat/ff.c | 27 ++++++++++++---------------
1 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/fs/fat/ff.c b/fs/fat/ff.c
index 66db1d6..622845a 100644
--- a/fs/fat/ff.c
+++ b/fs/fat/ff.c
@@ -93,6 +93,7 @@
#include <errno.h>
#include <malloc.h>
#include <linux/ctype.h>
+#include <filetype.h>
#include "ff.h" /* FatFs configurations and declarations */
#include "diskio.h" /* Declarations of low level disk I/O functions */
@@ -1533,7 +1534,8 @@ int follow_path ( /* 0(0): successful, !=0: error code */
*/
static int check_fs ( /* 0:The FAT BR, 1:Valid BR but not an FAT, 2:Not a BR, 3:Disk error */
FATFS *fs, /* File system object */
- DWORD sect /* Sector# (lba) to check if it is an FAT boot record or not */
+ DWORD sect, /* Sector# (lba) to check if it is an FAT boot record or not */
+ DWORD *bootsec
)
{
int ret;
@@ -1542,18 +1544,8 @@ static int check_fs ( /* 0:The FAT BR, 1:Valid BR but not an FAT, 2:Not a BR, 3:
ret = disk_read(fs, fs->win, sect, 1);
if (ret)
return ret;
- /* Check record signature (always placed at offset 510 even if the sector size is>512) */
- if (LD_WORD(&fs->win[BS_55AA]) != 0xAA55)
- return -ENODEV;
- /* Check "FAT" string */
- if ((LD_DWORD(&fs->win[BS_FilSysType]) & 0xFFFFFF) == 0x544146)
- return 0;
-
- if ((LD_DWORD(&fs->win[BS_FilSysType32]) & 0xFFFFFF) == 0x544146)
- return 0;
-
- return -ENODEV;
+ return is_fat_boot_sector(fs->win, bootsec);
}
/*
@@ -1565,6 +1557,7 @@ static int chk_mounted ( /* 0(0): successful, !=0: any error occurred */
)
{
BYTE fmt, b;
+ DWORD first_boot_sect;
DWORD bsect, fasize, tsect, sysect, nclst, szbfat;
WORD nrsv;
@@ -1579,9 +1572,13 @@ static int chk_mounted ( /* 0(0): successful, !=0: any error occurred */
return -EIO;
#endif
/* Search FAT partition on the drive. Supports only generic partitionings, FDISK and SFD. */
- fmt = check_fs(fs, bsect = 0); /* Check sector 0 if it is a VBR */
- if (fmt)
- return fmt; /* No FAT volume is found */
+ fmt = check_fs(fs, bsect = 0, &first_boot_sect); /* Check sector 0 if it is a VBR */
+ if (fmt && first_boot_sect != 0) {
+ /* Sector 0 is an MBR, now check for FAT in the first partition */
+ fmt = check_fs(fs, bsect = first_boot_sect, NULL);
+ if(fmt)
+ return fmt; /* No FAT volume is found */
+ }
/* Following code initializes the file system object */
--
1.7.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-09-16 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 20:33 [PATCH 1/2] [v2] filetype: Improve FAT detection Franck Jullien
2012-09-16 20:33 ` Franck Jullien [this message]
2012-09-17 5:49 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-17 6:08 ` Franck Jullien
2012-09-18 8:38 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2012-09-16 12:32 [PATCH 1/2] " Franck Jullien
2012-09-16 12:32 ` [PATCH 2/2] fs/fat: Handle MBR on the first sector Franck Jullien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347827613-25769-2-git-send-email-franck.jullien@gmail.com \
--to=franck.jullien@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox