From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: [PATCH 3/3] net/designware: fix phylib support
Date: Thu, 4 Oct 2012 09:00:27 +0200 [thread overview]
Message-ID: <1349334027-9525-3-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <1349334027-9525-1-git-send-email-plagnioj@jcrosoft.com>
/opt/work/barebox/drivers/net/designware.c: In function 'dwc_update_linkspeed':
/opt/work/barebox/drivers/net/designware.c:234:9: error: 'mac_p' undeclared (first use in this function)
/opt/work/barebox/drivers/net/designware.c:234:9: note: each undeclared identifier is reported only once for each function it appears in
/opt/work/barebox/drivers/net/designware.c: In function 'dwc_ether_open':
/opt/work/barebox/drivers/net/designware.c:254:6: error: too few arguments to function 'phy_device_connect'
/opt/work/barebox/include/linux/phy.h:252:5: note: declared here
/opt/work/barebox/drivers/net/designware.c: At top level:
/opt/work/barebox/drivers/net/designware.c:226:13: warning: 'dwc_update_linkspeed' defined but not used
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/net/designware.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/designware.c b/drivers/net/designware.c
index 6a36f14..ec51825 100644
--- a/drivers/net/designware.c
+++ b/drivers/net/designware.c
@@ -226,6 +226,7 @@ static int dwc_ether_init(struct eth_device *dev)
static void dwc_update_linkspeed(struct eth_device *edev)
{
struct dw_eth_dev *priv = edev->priv;
+ struct eth_mac_regs *mac_p = priv->mac_regs_p;
u32 conf;
if (priv->fix_mac_speed)
@@ -251,7 +252,7 @@ static int dwc_ether_open(struct eth_device *dev)
int ret;
ret = phy_device_connect(dev, &priv->miibus, priv->phy_addr,
- 0, PHY_INTERFACE_MODE_NA);
+ dwc_update_linkspeed, 0, PHY_INTERFACE_MODE_NA);
if (ret)
return ret;
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-04 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 7:00 [PATCH 1/3] net/designware: update version display to print user ID and Synosys ID Jean-Christophe PLAGNIOL-VILLARD
2012-10-04 7:00 ` [PATCH 2/3] net/designware: fix phy_addr type to int Jean-Christophe PLAGNIOL-VILLARD
2012-10-04 7:00 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-10-04 15:21 ` [PATCH 1/3] net/designware: update version display to print user ID and Synosys ID Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349334027-9525-3-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox