From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org
Cc: wsa@pengutronix.de
Subject: [PATCH 2/2] net fec: call fec_init at probe time
Date: Tue, 30 Oct 2012 17:30:06 +0100 [thread overview]
Message-ID: <1351614606-16461-3-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1351614606-16461-1-git-send-email-s.hauer@pengutronix.de>
fec_init() initializes some bits important for phy access, so do
this before the mdiobus is registered. This fixes mdiobus support
on i.MX28 boards in RMII mode.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/net/fec_imx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
index f6065aa..21ce38c 100644
--- a/drivers/net/fec_imx.c
+++ b/drivers/net/fec_imx.c
@@ -644,7 +644,6 @@ static int fec_probe(struct device_d *dev)
dev->priv = fec;
edev->priv = fec;
edev->open = fec_open;
- edev->init = fec_init;
edev->send = fec_send;
edev->recv = fec_recv;
edev->halt = fec_halt;
@@ -685,6 +684,8 @@ static int fec_probe(struct device_d *dev)
fec->xcv_type = pdata->xcv_type;
+ fec_init(edev);
+
if (fec->xcv_type != SEVENWIRE) {
fec->phy_init = pdata->phy_init;
fec->miibus.read = fec_miibus_read;
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-30 16:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 16:30 [PATCH] i.MX fec fixes Sascha Hauer
2012-10-30 16:30 ` [PATCH 1/2] net eth: make edev->init optional Sascha Hauer
2012-10-30 16:30 ` Sascha Hauer [this message]
2012-10-31 8:25 ` [PATCH 2/2] net fec: call fec_init at probe time Wolfram Sang
2012-10-31 20:52 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351614606-16461-3-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=wsa@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox