mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* Re: TX53: Not Bootable from next tree
@ 2012-11-06 13:49 Peter Wippich
  2012-11-07  8:04 ` Sascha Hauer
  2012-11-12  8:33 ` Sascha Hauer
  0 siblings, 2 replies; 10+ messages in thread
From: Peter Wippich @ 2012-11-06 13:49 UTC (permalink / raw)
  To: barebox


Hi,

got the same problem here. Double checked Board Version (8030) and
that I have the right binary (compressed with flash header). After 
flashing and reset nothing happens....

Used default config tx53stk5_defconfig.

Swiched back to old u-boot for now.

Regards,

Peter


|       Peter Wippich                   Voice: +49 30 46776411          |
|       G&W Instruments GmbH            fax:   +49 30 46776419          |
|       Gustav-Meyer-Allee 25, Geb. 12  Email: pewi@gw-instruments.de   |
|       D-13355 Berlin  / Germany                                       |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: TX53: Not Bootable from next tree
  2012-11-06 13:49 TX53: Not Bootable from next tree Peter Wippich
@ 2012-11-07  8:04 ` Sascha Hauer
  2012-11-12  8:33 ` Sascha Hauer
  1 sibling, 0 replies; 10+ messages in thread
From: Sascha Hauer @ 2012-11-07  8:04 UTC (permalink / raw)
  To: Peter Wippich; +Cc: barebox

On Tue, Nov 06, 2012 at 02:49:06PM +0100, Peter Wippich wrote:
> 
> Hi,
> 
> got the same problem here. Double checked Board Version (8030) and
> that I have the right binary (compressed with flash header). After
> flashing and reset nothing happens....
> 

I'll recheck when I'm back in the office next week. I have no idea what
is going wrong atm.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: TX53: Not Bootable from next tree
  2012-11-06 13:49 TX53: Not Bootable from next tree Peter Wippich
  2012-11-07  8:04 ` Sascha Hauer
@ 2012-11-12  8:33 ` Sascha Hauer
  2012-11-12 11:22   ` Peter Wippich
  2012-11-12 13:02   ` TX53: Not Bootable from next tree Christian Kapeller
  1 sibling, 2 replies; 10+ messages in thread
From: Sascha Hauer @ 2012-11-12  8:33 UTC (permalink / raw)
  To: Peter Wippich, g; +Cc: barebox

On Tue, Nov 06, 2012 at 02:49:06PM +0100, Peter Wippich wrote:
> 
> Hi,
> 
> got the same problem here. Double checked Board Version (8030) and
> that I have the right binary (compressed with flash header). After
> flashing and reset nothing happens....

I'm back in the office now and realized that we have the 1011
revision in our remotelab. That at least explains why I can't reproduce
this issue. Unfortunately I can't find the 8030 revision anywhere in the
office, I'll wait for my collegue.
In the meantime, could you try removing the call to
imx53_init_lowlevel() and try booting 2nd stage (from U-Boot or
redboot)?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: TX53: Not Bootable from next tree
  2012-11-12  8:33 ` Sascha Hauer
@ 2012-11-12 11:22   ` Peter Wippich
  2012-11-15  9:57     ` [TX53: boot fixes 0/2] Make TX53 bootable again Christian Kapeller
                       ` (2 more replies)
  2012-11-12 13:02   ` TX53: Not Bootable from next tree Christian Kapeller
  1 sibling, 3 replies; 10+ messages in thread
From: Peter Wippich @ 2012-11-12 11:22 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox, g




On Mon, 12 Nov 2012, Sascha Hauer wrote:

> On Tue, Nov 06, 2012 at 02:49:06PM +0100, Peter Wippich wrote:
>>
>> Hi,
>>
>> got the same problem here. Double checked Board Version (8030) and
>> that I have the right binary (compressed with flash header). After
>> flashing and reset nothing happens....
>
> I'm back in the office now and realized that we have the 1011
> revision in our remotelab. That at least explains why I can't reproduce
> this issue. Unfortunately I can't find the 8030 revision anywhere in the
> office, I'll wait for my collegue.
> In the meantime, could you try removing the call to
> imx53_init_lowlevel() and try booting 2nd stage (from U-Boot or
> redboot)?
>
> Sascha


Hi Sascha,

bad enough my test board is out for some customer tests. I'll try a second 
stage boot as soon as it is back.

Best regards,

Peter


>
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
>


|       Peter Wippich                   Voice: +49 30 46776411          |
|       G&W Instruments GmbH            fax:   +49 30 46776419          |
|       Gustav-Meyer-Allee 25, Geb. 12  Email: pewi@gw-instruments.de   |
|       D-13355 Berlin  / Germany                                       |


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: TX53: Not Bootable from next tree
  2012-11-12  8:33 ` Sascha Hauer
  2012-11-12 11:22   ` Peter Wippich
@ 2012-11-12 13:02   ` Christian Kapeller
  1 sibling, 0 replies; 10+ messages in thread
From: Christian Kapeller @ 2012-11-12 13:02 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox, g, Peter Wippich

Hi,

> In the meantime, could you try removing the call to
> imx53_init_lowlevel() and try booting 2nd stage (from U-Boot or
> redboot)?

2nd stage booting TX83-8030 from redboot works with and without call to
imx53_init_lowlevel (boards/karo-tx53/lowlevel.c)

I've also looked at the DCD sequence at the beginning of the redboot and
bb (CONFIG_PBL=y) binaries and saw, that what set's them appart is:

flash_header.entry RB: 0x8FFC0000
flash_header.entry BB: 0x71000000

flash_header.boot_data_size = 0x1fd87;
flash_header.boot_data_size = 0x40000;


Barebox has an additional DCD Item compared to redboot:

arch/arm/boards/karo-tx53/dcd-data-xx30.h line 15:
DCD_NAME_XX30[] = {
	DCD_WR_CMD(0x21c),
	DCD_ITEM(0x53fd4068, 0xffcc0fff),
	DCD_ITEM(0x53fd406c, 0x000fffc3),


The DCD_WR_CMD(0x21c) duplicates the the last entries of the
flash_header_section structure:

arch/arm/boards/karo-tx53/flash_header.h line 68:
	.dcd.command.tag	= DCD_COMMAND_WRITE_TAG,
#ifdef CONFIG_TX53_REV_1011
	.dcd.command.length	= cpu_to_be16(sizeof(struct imx_dcd_command) +
sizeof(dcd_entry)),
#elif defined(CONFIG_TX53_REV_XX30)
	.dcd.command.length	= cpu_to_be16(0x21c),

So the DCD_WR_CMD(0x21c) seems to be superfluous.



I've adjusted entry address, the boot_data_size, and removed the
DCD_WR_CMD entry, to match the flash header to that of redboot, and
flashed that. That didn't show any improvement.

Also here the situation is the same with and without imx53_init_lowlevel.


Cheers,
Christian


-- 
Christian Kapeller
cmotion GmbH
Kriehubergasse 16
1050 Wien / Austria
http://www.cmotion.eu

christian.kapeller@cmotion.eu
Phone: +43 1 789 1096 38

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [TX53: boot fixes 0/2] Make TX53 bootable again
  2012-11-12 11:22   ` Peter Wippich
@ 2012-11-15  9:57     ` Christian Kapeller
  2012-11-15 11:46       ` Sascha Hauer
  2012-11-15  9:57     ` [TX53: boot fixes 1/2] tx53: Fix unbootable TX53-8030 Christian Kapeller
  2012-11-15  9:57     ` [TX53: boot fixes 2/2] tx53: remove reset() when not doing lowlevel init Christian Kapeller
  2 siblings, 1 reply; 10+ messages in thread
From: Christian Kapeller @ 2012-11-15  9:57 UTC (permalink / raw)
  To: barebox; +Cc: Günter Gebhardt, g, Peter Wippich

Currently KaRo TX53-8030 soc module support is present in next branch, but
compiling the default config tx53stk5_defconfig results in an unbootable image.

This series 
 * makes the TX53-8030 board boot again [1/2]
 * fixes compilation of the TX53 board with PBL_IMAGE=n and DO_LOWLEVEL_RESET=n [2/2]

Christian Kapeller (2):
  tx53: Fix unbootable TX53-8030.
  tx53: remove reset() when not doing lowlevel init.

 arch/arm/boards/karo-tx53/dcd-data-xx30.h |    1 -
 arch/arm/boards/karo-tx53/lowlevel.c      |    3 +++
 2 files changed, 3 insertions(+), 1 deletions(-)

-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [TX53: boot fixes 1/2] tx53: Fix unbootable TX53-8030.
  2012-11-12 11:22   ` Peter Wippich
  2012-11-15  9:57     ` [TX53: boot fixes 0/2] Make TX53 bootable again Christian Kapeller
@ 2012-11-15  9:57     ` Christian Kapeller
  2012-11-15  9:57     ` [TX53: boot fixes 2/2] tx53: remove reset() when not doing lowlevel init Christian Kapeller
  2 siblings, 0 replies; 10+ messages in thread
From: Christian Kapeller @ 2012-11-15  9:57 UTC (permalink / raw)
  To: barebox; +Cc: Günter Gebhardt, g, Peter Wippich

This patch remove a superfluous DCD command in TX53-xx30 flash header.
The entry DCD_WR_CMD(0x21c) just duplicates the contents of the last
imx_flash_header_v2 struct member dcd.

Removal of this DCD entry is needed to make the TX53 board boot again
from NAND.

Signed-off-by: Christian Kapeller <christian.kapeller@cmotion.eu>
---
 arch/arm/boards/karo-tx53/dcd-data-xx30.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boards/karo-tx53/dcd-data-xx30.h b/arch/arm/boards/karo-tx53/dcd-data-xx30.h
index aa569c2..cb982dc 100644
--- a/arch/arm/boards/karo-tx53/dcd-data-xx30.h
+++ b/arch/arm/boards/karo-tx53/dcd-data-xx30.h
@@ -13,7 +13,6 @@
  */
 
 DCD_NAME_XX30[] = {
-	DCD_WR_CMD(0x21c),
 	DCD_ITEM(0x53fd4068, 0xffcc0fff),
 	DCD_ITEM(0x53fd406c, 0x000fffc3),
 	DCD_ITEM(0x53fd4070, 0x033c0000),
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [TX53: boot fixes 2/2] tx53: remove reset() when not doing lowlevel init.
  2012-11-12 11:22   ` Peter Wippich
  2012-11-15  9:57     ` [TX53: boot fixes 0/2] Make TX53 bootable again Christian Kapeller
  2012-11-15  9:57     ` [TX53: boot fixes 1/2] tx53: Fix unbootable TX53-8030 Christian Kapeller
@ 2012-11-15  9:57     ` Christian Kapeller
  2 siblings, 0 replies; 10+ messages in thread
From: Christian Kapeller @ 2012-11-15  9:57 UTC (permalink / raw)
  To: barebox; +Cc: Günter Gebhardt, g, Peter Wippich

This patch fixes a linker error when PBL_IMAGE=n and DO_LOW_LEVEL_INIT=n.
In this configuration the symbol reset() was present multiple times,
and prevented the barebox image to be linked.


Signed-off-by: Christian Kapeller <christian.kapeller@cmotion.eu>
---
 arch/arm/boards/karo-tx53/lowlevel.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boards/karo-tx53/lowlevel.c b/arch/arm/boards/karo-tx53/lowlevel.c
index 6b7314c..0ca164b 100644
--- a/arch/arm/boards/karo-tx53/lowlevel.c
+++ b/arch/arm/boards/karo-tx53/lowlevel.c
@@ -3,6 +3,8 @@
 #include <asm/barebox-arm.h>
 #include <mach/imx5.h>
 
+#ifdef CONFIG_MACH_DO_LOWLEVEL_INIT
+
 void __naked reset(void)
 {
 	common_reset();
@@ -17,3 +19,4 @@ void __naked reset(void)
 
 	board_init_lowlevel_return();
 }
+#endif
-- 
1.7.5.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [TX53: boot fixes 0/2] Make TX53 bootable again
  2012-11-15  9:57     ` [TX53: boot fixes 0/2] Make TX53 bootable again Christian Kapeller
@ 2012-11-15 11:46       ` Sascha Hauer
  2012-11-15 12:00         ` Christian Kapeller
  0 siblings, 1 reply; 10+ messages in thread
From: Sascha Hauer @ 2012-11-15 11:46 UTC (permalink / raw)
  To: Christian Kapeller; +Cc: Günter Gebhardt, barebox, g, Peter Wippich

On Thu, Nov 15, 2012 at 10:57:13AM +0100, Christian Kapeller wrote:
> Currently KaRo TX53-8030 soc module support is present in next branch, but
> compiling the default config tx53stk5_defconfig results in an unbootable image.
> 
> This series 
>  * makes the TX53-8030 board boot again [1/2]
>  * fixes compilation of the TX53 board with PBL_IMAGE=n and DO_LOWLEVEL_RESET=n [2/2]

Applied. Thanks for fixing this.

Sascha

> 
> Christian Kapeller (2):
>   tx53: Fix unbootable TX53-8030.
>   tx53: remove reset() when not doing lowlevel init.
> 
>  arch/arm/boards/karo-tx53/dcd-data-xx30.h |    1 -
>  arch/arm/boards/karo-tx53/lowlevel.c      |    3 +++
>  2 files changed, 3 insertions(+), 1 deletions(-)
> 
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [TX53: boot fixes 0/2] Make TX53 bootable again
  2012-11-15 11:46       ` Sascha Hauer
@ 2012-11-15 12:00         ` Christian Kapeller
  0 siblings, 0 replies; 10+ messages in thread
From: Christian Kapeller @ 2012-11-15 12:00 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: Günter Gebhardt, barebox, g, Peter Wippich

On 11/15/2012 12:46 PM, Sascha Hauer wrote:
> On Thu, Nov 15, 2012 at 10:57:13AM +0100, Christian Kapeller wrote:
>> Currently KaRo TX53-8030 soc module support is present in next branch, but
>> compiling the default config tx53stk5_defconfig results in an unbootable image.
>>
>> This series 
>>  * makes the TX53-8030 board boot again [1/2]
>>  * fixes compilation of the TX53 board with PBL_IMAGE=n and DO_LOWLEVEL_RESET=n [2/2]
> 
> Applied. Thanks for fixing this.

You're welcome. After all, I am happy to enable others to use hot piece of
boot software on the Karo hardware. Also it is good to see, that other
people are using it.

Cheers,
Christian





_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2012-11-15 12:01 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-06 13:49 TX53: Not Bootable from next tree Peter Wippich
2012-11-07  8:04 ` Sascha Hauer
2012-11-12  8:33 ` Sascha Hauer
2012-11-12 11:22   ` Peter Wippich
2012-11-15  9:57     ` [TX53: boot fixes 0/2] Make TX53 bootable again Christian Kapeller
2012-11-15 11:46       ` Sascha Hauer
2012-11-15 12:00         ` Christian Kapeller
2012-11-15  9:57     ` [TX53: boot fixes 1/2] tx53: Fix unbootable TX53-8030 Christian Kapeller
2012-11-15  9:57     ` [TX53: boot fixes 2/2] tx53: remove reset() when not doing lowlevel init Christian Kapeller
2012-11-12 13:02   ` TX53: Not Bootable from next tree Christian Kapeller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox