From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tc6MK-0006EO-Hm for barebox@lists.infradead.org; Sat, 24 Nov 2012 03:24:49 +0000 Received: by mail-wi0-f177.google.com with SMTP id c10so1468505wiw.0 for ; Fri, 23 Nov 2012 19:24:45 -0800 (PST) From: Vicente Bergas Date: Sat, 24 Nov 2012 04:24:23 +0100 Message-Id: <1353727464-15175-2-git-send-email-vicencb@gmail.com> In-Reply-To: <1353727464-15175-1-git-send-email-vicencb@gmail.com> References: <1353727464-15175-1-git-send-email-vicencb@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: barebox-bounces@lists.infradead.org Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: [PATCH 1/2] uimage: fix misunderstanding in common/uimage.c To: barebox@lists.infradead.org Cc: Vicente Bergas The option of reading the file at once was discarded because the option of increasing the buffer size provided almost the same benefit. Signed-off-by: Vicente Bergas --- common/uimage.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/common/uimage.c b/common/uimage.c index 3f5a3d5..8bcbfdd 100644 --- a/common/uimage.c +++ b/common/uimage.c @@ -28,8 +28,6 @@ #include #include #include -#include -#include #ifdef CONFIG_UIMAGE_MULTI static inline int uimage_is_multi_image(struct uimage_handle *handle) @@ -384,33 +382,11 @@ struct resource *file_to_sdram(const char *filename, unsigned long adr) size_t ofs = 0; size_t now; int fd; - struct stat s; fd = open(filename, O_RDONLY); if (fd < 0) return NULL; - /* TODO: use fstat(fd, &s) when implemented and avoid reopening file */ - if (stat(filename, &s) == 0 && s.st_size <= SZ_1G) { - /* - * As the file size is known we can read it at once and improve - * transfer speed. - */ - size = s.st_size; - res = request_sdram_region("image", adr, size); - if (!res) { - printf("unable to request SDRAM 0x%08lx-0x%08lx\n", - adr, adr + size - 1); - goto out; - } - - now = read_full(fd, (void *)(res->start), size); - if (now < size) { - release_sdram_region(res); - res = NULL; - } - goto out; - } while (1) { res = request_sdram_region("image", adr, size); if (!res) { -- 1.8.0 _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox