mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Sascha Hauer" <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH] Cleanup Kconfig files
Date: Mon, 26 Nov 2012 18:00:54 +0400	[thread overview]
Message-ID: <1353938454.660390986@f209.mail.ru> (raw)
In-Reply-To: <20121126081602.GW10369@pengutronix.de>

> On Sat, Nov 24, 2012 at 10:53:29PM +0400, Alexander Shiyan wrote:
> > This patch provides a global cleanup barebox Kconfig files. This includes
> > replacing spaces to tabs, formatting in accordance format, removing
> > extraneous lines and spaces. No functional changes.
> > 
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 3afd885..01fe9de 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -19,7 +19,7 @@ config ARM_LINUX
> >  config HAVE_MACH_ARM_HEAD
> >  	bool
> >  
> > -menu "System Type                   "
> > +menu "System Type"
> 
> These whitespaces are present on purpose. They are there for aligning
> the arrows in menus in make menuconfig. I tend to say that this is a
> good change anyway, because counting the spaces to align line lengths
> is something which hurts during review (and I can't remember having
> done this before).
> 
> If nobody objects I'll apply it. If somebody objects, I probably say him
> that he should provide a patch for Kconfig instead.

I can remade some parts if necessary since this output is produced
via cleanup program. Also, is necessary, I can remade this patch for
the "next" branch.

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-11-26 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-24 18:53 Alexander Shiyan
2012-11-26  8:16 ` Sascha Hauer
2012-11-26 14:00   ` Alexander Shiyan [this message]
2012-12-08  6:51   ` Alexander Shiyan
2012-12-08 11:16     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353938454.660390986@f209.mail.ru \
    --to=shc_work@mail.ru \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox