mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] MIPS: pbl: fix none compression support
@ 2013-02-04 20:00 Antony Pavlov
  2013-02-05  8:44 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Antony Pavlov @ 2013-02-04 20:00 UTC (permalink / raw)
  To: barebox

Here's the error message:

  AS      arch/mips/pbl/piggy.shipped.o
  arch/mips/pbl/piggy.shipped.S: Assembler messages:
  arch/mips/pbl/piggy.shipped.S:1: Error: unrecognized opcode `globl input_data'
  make[1]: *** [arch/mips/pbl/piggy.shipped.o] Error 1
  make: *** [zbarebox.bin] Error 2

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 arch/mips/pbl/piggy.shipped.S |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/mips/pbl/piggy.shipped.S b/arch/mips/pbl/piggy.shipped.S
index 963262d..8a35f6b 100644
--- a/arch/mips/pbl/piggy.shipped.S
+++ b/arch/mips/pbl/piggy.shipped.S
@@ -1,6 +1,6 @@
-	.section .piggydata,#alloc
-	.globl  input_data
-input_data:
-	.incbin "arch/mips/pbl/piggy.shipped"
-	.globl  input_data_end
-input_data_end:
+#include <asm/asm.h>
+
+	.section .data
+EXPORT(input_data)
+	.incbin	"arch/mips/pbl/piggy.shipped"
+EXPORT(input_data_end)
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: pbl: fix none compression support
  2013-02-04 20:00 [PATCH] MIPS: pbl: fix none compression support Antony Pavlov
@ 2013-02-05  8:44 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2013-02-05  8:44 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: barebox

On Tue, Feb 05, 2013 at 12:00:30AM +0400, Antony Pavlov wrote:
> Here's the error message:
> 
>   AS      arch/mips/pbl/piggy.shipped.o
>   arch/mips/pbl/piggy.shipped.S: Assembler messages:
>   arch/mips/pbl/piggy.shipped.S:1: Error: unrecognized opcode `globl input_data'
>   make[1]: *** [arch/mips/pbl/piggy.shipped.o] Error 1
>   make: *** [zbarebox.bin] Error 2
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

> ---
>  arch/mips/pbl/piggy.shipped.S |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/mips/pbl/piggy.shipped.S b/arch/mips/pbl/piggy.shipped.S
> index 963262d..8a35f6b 100644
> --- a/arch/mips/pbl/piggy.shipped.S
> +++ b/arch/mips/pbl/piggy.shipped.S
> @@ -1,6 +1,6 @@
> -	.section .piggydata,#alloc
> -	.globl  input_data
> -input_data:
> -	.incbin "arch/mips/pbl/piggy.shipped"
> -	.globl  input_data_end
> -input_data_end:
> +#include <asm/asm.h>
> +
> +	.section .data
> +EXPORT(input_data)
> +	.incbin	"arch/mips/pbl/piggy.shipped"
> +EXPORT(input_data_end)
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-05  8:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-04 20:00 [PATCH] MIPS: pbl: fix none compression support Antony Pavlov
2013-02-05  8:44 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox