From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: barebox@lists.infradead.org
Subject: [PATCH 3/4] macb: report timeout on send
Date: Tue, 5 Feb 2013 11:15:05 +0100 [thread overview]
Message-ID: <1360059306-31118-3-git-send-email-plagnioj@jcrosoft.com> (raw)
In-Reply-To: <1360059306-31118-1-git-send-email-plagnioj@jcrosoft.com>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
drivers/net/macb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 8eac4a8..641b365 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -111,6 +111,7 @@ static int macb_send(struct eth_device *edev, void *packet,
{
struct macb_device *macb = edev->priv;
unsigned long ctrl;
+ int ret;
dev_dbg(macb->dev, "%s\n", __func__);
@@ -132,9 +133,10 @@ static int macb_send(struct eth_device *edev, void *packet,
dev_err(macb->dev, "TX underrun\n");
if (ctrl & TXBUF_EXHAUSTED)
dev_err(macb->dev, "TX buffers exhausted in mid frame\n");
+ if (ret)
+ dev_err(macb->dev,"TX timeout\n");
- /* No one cares anyway */
- return 0;
+ return ret;
}
static void reclaim_rx_buffers(struct macb_device *macb,
--
1.7.10.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2013-02-05 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 10:12 [PATCH 0/4] macb: more fixes Jean-Christophe PLAGNIOL-VILLARD
2013-02-05 10:15 ` [PATCH 1/4] macb: use dev_xx message Jean-Christophe PLAGNIOL-VILLARD
2013-02-05 10:15 ` [PATCH 2/4] macb: register the phy after the macb is init Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 19:35 ` Sascha Hauer
2013-02-06 19:37 ` Sascha Hauer
2013-02-06 20:16 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 20:32 ` Sascha Hauer
2013-02-06 20:34 ` Jean-Christophe PLAGNIOL-VILLARD
2013-02-06 20:39 ` Sascha Hauer
2013-02-05 10:15 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2013-02-05 10:15 ` [PATCH 4/4] macb: drop non used define Jean-Christophe PLAGNIOL-VILLARD
2013-02-08 8:36 ` [PATCH 1/4] macb: use dev_xx message Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360059306-31118-3-git-send-email-plagnioj@jcrosoft.com \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox