Re[2]: [RFC] Add Generic GPIO driver

["Alexander Shiyan" <shc_work@mail.ru>]

> On Mon, Feb 18, 2013 at 02:13:22PM +0400, Alexander Shiyan wrote:
> > > On Fri, Feb 15, 2013 at 10:49:27PM +0400, Alexander Shiyan wrote:
> > > > This patch adds generic memory-mapped GPIO controller support.
> > > > Code taken from Linux Kernel and adopted for barebox.
> > > 
> > > I'm fine with this if you add a user for it. I wonder though if it's
> > > worth it to have this driver for barebox. If I have a driver in the
> > > kernel that already uses it, then this makes it simple to copy it, but
> > > should I have to write a new gpio driver, I'm unsure if it's simpler
> > > to write a new gpio driver or to register with the generic gpio
> > > driver.
> > 
> > Here's an example that I'm checking:
> 
> Ok, this indeed looks nice and short. You convinced me ;)
> 
> As said, I'm fine with the generic gpio driver if you add the below as
> first user.

I still beg to consider patch for generic GPIO separately.
Then I will send you two completely different versions of the implementation
GPIO for CLPS711X for consideration.

...
> > /*
> >  * Copyright (C) 2013 Alexander Shiyan <shc_work@mail.ru>
> >  *
> >  * This program is free software; you can redistribute it and/or
> >  * modify it under the terms of the GNU General Public License as
> >  * published by the Free Software Foundation; either version 2 of
> >  * the License, or (at your option) any later version.
> >  */
> > 
> > #include <init.h>
> > #include <common.h>
> > #include <malloc.h>
> > 
> > #include <linux/basic_mmio_gpio.h>
...

---
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox