[PATCH 1/1] highbank: add wfi for poweroff

[PATCH 1/1] highbank: add wfi for poweroff

[Jean-Christophe PLAGNIOL-VILLARD]

needed by the real hardware

Cc: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
---
 arch/arm/mach-highbank/reset.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
index 630672a..b9664e4 100644
--- a/arch/arm/mach-highbank/reset.c
+++ b/arch/arm/mach-highbank/reset.c
@@ -23,5 +23,7 @@ void __noreturn poweroff()
 	shutdown_barebox();
 
 	hingbank_set_pwr_shutdown();
+	asm("	wfi");
+
 	while(1);
 }
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] highbank: add wfi for poweroff

[Rob Herring]

On 02/20/2013 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> needed by the real hardware
> 
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  arch/arm/mach-highbank/reset.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
> index 630672a..b9664e4 100644
> --- a/arch/arm/mach-highbank/reset.c
> +++ b/arch/arm/mach-highbank/reset.c
> @@ -23,5 +23,7 @@ void __noreturn poweroff()
>  	shutdown_barebox();
>  
>  	hingbank_set_pwr_shutdown();
> +	asm("	wfi");
> +

This will break on old compilers or v5 builds. I personally don't care,
but some people do.

Rob

>  	while(1);
>  }
> 


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] highbank: add wfi for poweroff

[Jean-Christophe PLAGNIOL-VILLARD]

On 08:09 Wed 20 Feb     , Rob Herring wrote:
> On 02/20/2013 06:55 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > needed by the real hardware
> > 
> > Cc: Rob Herring <rob.herring@calxeda.com>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  arch/arm/mach-highbank/reset.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/mach-highbank/reset.c b/arch/arm/mach-highbank/reset.c
> > index 630672a..b9664e4 100644
> > --- a/arch/arm/mach-highbank/reset.c
> > +++ b/arch/arm/mach-highbank/reset.c
> > @@ -23,5 +23,7 @@ void __noreturn poweroff()
> >  	shutdown_barebox();
> >  
> >  	hingbank_set_pwr_shutdown();
> > +	asm("	wfi");
> > +
> 
> This will break on old compilers or v5 builds. I personally don't care,
> but some people do.
I do not care too

and highbank is a v7 so I expect you use the proper compiler

Best Regards,
J.
> 
> Rob
> 
> >  	while(1);
> >  }
> > 
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] highbank: add wfi for poweroff

[Sascha Hauer]

On Wed, Feb 20, 2013 at 01:55:36PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> needed by the real hardware
> 
> Cc: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Applied, thanks.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox